Skip to content

test(bigquery-jdbc): do not merge #13528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Neenu1995 wants to merge 1 commit into
base: main
Choose a base branch
from
+48 −0
Open

test(bigquery-jdbc): do not merge #13528

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 48 additions & 0 deletions java-bigquery-jdbc/src/test/java/com/google/cloud/bigquery/jdbc/it/ITBigQueryJDBCTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,10 @@
import java.time.LocalTime;
import java.util.Properties;
import java.util.Random;
import java.util.concurrent.ExecutorService;
import java.util.concurrent.Executors;
import java.util.concurrent.Future;
import java.util.concurrent.TimeUnit;
import java.util.function.BiFunction;
import org.junit.jupiter.api.AfterAll;
import org.junit.jupiter.api.Assertions;
Expand Down Expand Up @@ -406,6 +410,50 @@ public void testLocation() throws SQLException {
connection2.close();
}

@Test
public void testCancelLocation() throws Exception {
String connection_uri =
"jdbc:bigquery://https://www.googleapis.com/bigquery/v2:443;PROJECTID="
+ PROJECT_ID
+ ";OAUTHTYPE=3;LOCATION=EU";

Driver driver = BigQueryDriver.getRegisteredDriver();
Connection connection = driver.connect(connection_uri, new Properties());
Statement statement = connection.createStatement();

// Query a dataset in the EU with a heavy query so that we can cancel it while it runs.
String query =
"SELECT COUNT(*) FROM `bigquery-public-data.covid19_italy_eu.data_by_province` a "
+ "CROSS JOIN `bigquery-public-data.covid19_italy_eu.data_by_province` b "
+ "CROSS JOIN `bigquery-public-data.covid19_italy_eu.data_by_province` c";

// Run the query in a separate thread so we can cancel it from the main thread
ExecutorService executor = Executors.newSingleThreadExecutor();
Future<SQLException> future = executor.submit(() -> {
try {
statement.executeQuery(query);
return null;
} catch (SQLException e) {
return e;
}
});

// Wait a short moment to let the query submit and start running
Thread.sleep(1500);

// Cancel the query execution
statement.cancel();

// Verify that the query threw a SQLException indicating it was cancelled
SQLException exception = future.get(15, TimeUnit.SECONDS);
assertNotNull(exception, "Expected SQLException to be thrown due to cancellation");
assertTrue(exception.getMessage().contains("cancelled") || exception.getMessage().contains("Job was cancelled") || exception.getMessage().contains("Query was cancelled"),
"Unexpected exception message: " + exception.getMessage());

connection.close();
executor.shutdown();
}
Comment on lines +414 to +455

@gemini-code-assist gemini-code-assist Bot Jun 19, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The Connection, Statement, and ExecutorService resources are not closed in an exception-safe manner. If an assertion fails or an exception is thrown (e.g., during future.get()), the connection.close() and executor.shutdown() calls will be bypassed, leading to resource leaks. Use try-with-resources for the JDBC resources and a finally block to ensure the executor is shut down.

  @Test
  public void testCancelLocation() throws Exception {
    String connection_uri =
        "jdbc:bigquery://https://www.googleapis.com/bigquery/v2:443;PROJECTID="
            + PROJECT_ID
            + ";OAUTHTYPE=3;LOCATION=EU";

    Driver driver = BigQueryDriver.getRegisteredDriver();
    ExecutorService executor = Executors.newSingleThreadExecutor();
    try (Connection connection = driver.connect(connection_uri, new Properties());
        Statement statement = connection.createStatement()) {

      // Query a dataset in the EU with a heavy query so that we can cancel it while it runs.
      String query =
          "SELECT COUNT(*) FROM bigquery_public_data.covid19_italy_eu.data_by_province a "
              + "CROSS JOIN bigquery_public_data.covid19_italy_eu.data_by_province b "
              + "CROSS JOIN bigquery_public_data.covid19_italy_eu.data_by_province c";

      // Run the query in a separate thread so we can cancel it from the main thread
      Future<SQLException> future = executor.submit(() -> {
        try {
          statement.executeQuery(query);
          return null;
        } catch (SQLException e) {
          return e;
        }
      });

      // Wait a short moment to let the query submit and start running
      Thread.sleep(1500);

      // Cancel the query execution
      statement.cancel();

      // Verify that the query threw a SQLException indicating it was cancelled
      SQLException exception = future.get(15, TimeUnit.SECONDS);
      assertNotNull(exception, "Expected SQLException to be thrown due to cancellation");
      assertTrue(exception.getMessage().contains("cancelled") || exception.getMessage().contains("Job was cancelled") || exception.getMessage().contains("Query was cancelled"),
          "Unexpected exception message: " + exception.getMessage());
    } finally {
      executor.shutdown();
    }
  }
References
  1. When managing a collection of closeable resources, ensure they are closed in the reverse order of their creation (LIFO). The implementation must be exception-safe to prevent resource leaks, meaning all opened resources should be closed even if exceptions occur during their creation or closing.


@Test
public void testIncorrectLocation() throws SQLException {
String connection_uri =
Expand Down
Loading