fix(spanner): fail fast when inline-begin DML returns no transaction id#13536
Merged
Conversation
Sync executeUpdate/executeBatchUpdate and async batchUpdateAsync left transactionIdFuture unresolved when a begin-requesting DML response carried no transaction metadata, so commit blocked on the 60s wait and surfaced DEADLINE_EXCEEDED. Mirror executeUpdateAsync: raise FAILED_PRECONDITION via onError so the future resolves and the transaction retries or propagates. Use getId().isEmpty() consistently and add regression coverage via a mock omit-transaction hook.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the handling of inline begin transactions in TransactionRunnerImpl by introducing helper methods to check for non-empty transaction IDs and enforce that a transaction is returned when expected. It also updates tests in InlineBeginTransactionTest to use a shorter transaction wait timeout, and refactors MockSpannerServiceImpl to conditionally omit transaction metadata when simulating inline begin transaction omissions. There are no review comments, so I have no feedback to provide.
olavloite
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync executeUpdate/executeBatchUpdate and async batchUpdateAsync left transactionIdFuture unresolved when a begin-requesting DML response carried no transaction metadata, so commit blocked on the 60s wait and surfaced DEADLINE_EXCEEDED. Mirror executeUpdateAsync: raise FAILED_PRECONDITION via onError so the future resolves and the transaction retries or propagates. Use getId().isEmpty() consistently and add regression coverage via a mock omit-transaction hook.