fix(release): resolve first-party-dependencies SNAPSHOT in libraries-bom#13790
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the version replacement logic in generation/apply_versions.sh to dynamically match any XML tag instead of only <version>, and updates a dependency version in java-cloud-bom/libraries-bom/pom.xml. Feedback on the shell script points out that the new regular expression might incorrectly replace the first XML tag on lines containing multiple tags (such as <groupId> or <artifactId>) instead of the intended version tag. A code suggestion was provided to restrict the match to the tag immediately preceding the version update comment.
jinseopkim0
force-pushed
the
fix-libraries-bom-release-deps
branch
from
July 16, 2026 14:43
3cf571d to
115125b
Compare
jinseopkim0
marked this pull request as ready for review
July 16, 2026 14:44
jinseopkim0
enabled auto-merge (squash)
July 16, 2026 14:45
blakeli0
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves the stale SNAPSHOT version of first-party-dependencies in libraries-bom which caused release builds to fail.