fix(storage): handle upload errors before pipeline setup

createWriteStream starts the simple or resumable upload before installing the pipeline that normally owns fileWriteStream errors. If startup fails synchronously, fileWriteStream and the public write stream are destroyed before pipeline() runs. Node 24 and newer then throw ERR_STREAM_UNABLE_TO_PIPE while attaching the already-invalid streams, and the original upload error can escape uncaught.

Install a temporary error listener before upload startup and forward any early failure through the existing pipeline callback. If startup destroyed the source, destination, or public stream, tear down the remaining stream and skip pipeline setup. Remove the temporary listener once the normal pipeline is ready to take ownership.

This restores the existing createWriteStream error tests on Node 24 and 26 without changing successful upload behavior.

Author: rockwotj

handwritten/storage/src/file.ts

@@ -2192,12 +2192,28 @@ class File extends ServiceObject<File, FileMetadata> {
     });
 
     writeStream.once('writing', () => {
+      const onPrePipelineError = (error: Error) => {
+        pipelineCallback(error);
+      };
+      fileWriteStream.once('error', onPrePipelineError);
+
       if (options.resumable === false) {
         this.startSimpleUpload_(fileWriteStream, options);
       } else {
         this.startResumableUpload_(fileWriteStream, options);
       }
 
+      if (
+        fileWriteStream.destroyed ||
+        writeStream.destroyed ||
+        emitStream.destroyed
+      ) {
+        emitStream.destroy();
+        return;
+      }
+
+      fileWriteStream.removeListener('error', onPrePipelineError);
+
       // remove temporary noop listener as we now create a pipeline that handles the errors
       emitStream.removeListener('error', noop);