Skip to content

Commit b053d0e

Browse files
shivanee-pquirogas
andauthored
chore: clean up per-package eslintrc configurations (#8266)
* style(packages): clean up legacy per-package configurations and remove generator template configs * chore: update baselines * fix(generator): inline Prettier configuration and declare gts runtime dependency * fix(generator): add root property to ESLint config to stop traversal in isolated CI jobs * fix(generator): ignore system-test directory during ESLint verification in isolated CI runs * fix(generator): use recursive globs in ESLint ignore to correctly match subdirectories in unpacked CI test packages * fix(eslint): add recursive ignorePatterns to parent configs to ignore compiled artifacts and test fixtures when per-package configs are removed --------- Co-authored-by: Santiago Quiroga <22756465+quirogas@users.noreply.github.com>
1 parent b829784 commit b053d0e

105 files changed

Lines changed: 34 additions & 647 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.eslintrc.json

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,13 @@
11
{
22
"extends": "./node_modules/gts",
3-
"root": true
3+
"root": true,
4+
"ignorePatterns": [
5+
"**/node_modules",
6+
"**/build",
7+
"**/system-test",
8+
"**/test/fixtures",
9+
"**/samples/generated",
10+
"**/.coverage",
11+
"**/coverage"
12+
]
413
}
Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,11 @@
11
**/node_modules
22
**/coverage
3-
test/fixtures
4-
build/
5-
docs/
6-
protos/
7-
samples/generated/
3+
**/.coverage
4+
**/test/fixtures
5+
**/build
6+
**/docs
7+
**/protos
8+
**/system-test
9+
**/samples/generated
810
bazel-gapic-generator-typescript/
911
test-fixtures/
Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,14 @@
11
{
2-
"extends": "./node_modules/gts"
2+
"extends": "./node_modules/gts",
3+
"root": true,
4+
"ignorePatterns": [
5+
"**/node_modules",
6+
"**/build",
7+
"**/system-test",
8+
"**/test/fixtures",
9+
"**/samples/generated",
10+
"**/.coverage",
11+
"**/coverage"
12+
]
313
}
414

core/generator/gapic-generator-typescript/.prettierrc.cjs

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,10 @@
1313
// limitations under the License.
1414

1515
module.exports = {
16-
...require('gts/.prettierrc.json')
17-
}
16+
bracketSpacing: false,
17+
singleQuote: true,
18+
trailingComma: 'all',
19+
arrowParens: 'avoid',
20+
};
1821

1922

core/generator/gapic-generator-typescript/BUILD.bazel

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ npm_runtime_dependencies = [
4040
"//:node_modules/yargs",
4141
"//:node_modules/google-gax",
4242
"//:node_modules/prettier",
43+
"//:node_modules/gts",
4344
]
4445

4546
npm_test_dependencies = npm_runtime_dependencies + [

core/generator/gapic-generator-typescript/baselines/asset-esm/.eslintignore.baseline

Lines changed: 0 additions & 11 deletions
This file was deleted.

core/generator/gapic-generator-typescript/baselines/asset-esm/.eslintrc.json.baseline

Lines changed: 0 additions & 4 deletions
This file was deleted.

core/generator/gapic-generator-typescript/baselines/asset/.eslintignore.baseline

Lines changed: 0 additions & 7 deletions
This file was deleted.

core/generator/gapic-generator-typescript/baselines/asset/.eslintrc.json.baseline

Lines changed: 0 additions & 4 deletions
This file was deleted.

core/generator/gapic-generator-typescript/baselines/bigquery-storage-esm/.eslintignore.baseline

Lines changed: 0 additions & 11 deletions
This file was deleted.

0 commit comments

Comments
 (0)