fix: for bigquery-storage add protobufjs to dependencies#8243
Open
danieljbruce wants to merge 1 commit into
Open
fix: for bigquery-storage add protobufjs to dependencies#8243danieljbruce wants to merge 1 commit into
danieljbruce wants to merge 1 commit into
Conversation
danieljbruce
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the package.json for the BigQuery Storage handwritten library to include protobufjs as a direct dependency, matching its existing version in peerDependencies. I have no feedback to provide as there were no review comments to evaluate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
https://github.com/googleapis/google-cloud-node/actions/runs/25682649429/job/75398015952 indicates the release is failing to compile for bigquery-storage. Although the tests seem to work perfectly fine when run locally, running tests in our CI environment are failing. The current hypothesis is that this is because the protobufjs dependency is only in peer dependencies and the build is still working locally because the persistent local environment is able to find the protobufjs dependency from another location on time whereas the CI build can't find any reliable protobufjs dependency to rely on from a clean build.
Impact
Unblocks the release for google-cloud-node