fix: strip trailing slashes from automatic GDCH audience#8692
Open
jerrylin3321 wants to merge 3 commits into
Open
fix: strip trailing slashes from automatic GDCH audience#8692jerrylin3321 wants to merge 3 commits into
jerrylin3321 wants to merge 3 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request modifies the audience formatting in GoogleAuth to remove the trailing slash from the GDCH audience URL, and updates the corresponding unit tests to reflect this change. There are no review comments, and the changes look correct.
macastelaz
approved these changes
Jun 22, 2026
macastelaz
left a comment
macastelaz
left a comment
Contributor
There was a problem hiding this comment.
Thanks for catching and fixing this!
pearigee
added
the
kokoro:force-run
pearigee
approved these changes
Jun 22, 2026
yoshi-kokoro
removed
the
kokoro:force-run
pearigee
added
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up PR to #8301
Fixes #8289
See testing in go/gemini-cli-sa