Skip to content

Commit 21e4480

Browse files
committed
remove special handling for protobuf in favor of fixing it
1 parent bdbdf4b commit 21e4480

2 files changed

Lines changed: 1 addition & 9 deletions

File tree

dev/src/Command/DocFxCommand.php

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -297,10 +297,7 @@ private function validate(ClassNode $class, OutputInterface $output): bool
297297
{
298298
$valid = true;
299299
$emptyRef = '<options=bold>empty</>';
300-
$isGenerated = $class->isProtobufMessageClass()
301-
|| $class->isProtobufEnumClass()
302-
|| $class->isServiceClass()
303-
|| $class->isProtobufLibrary();
300+
$isGenerated = $class->isProtobufMessageClass() || $class->isProtobufEnumClass() || $class->isServiceClass();
304301
foreach (array_merge([$class], $class->getMethods(), $class->getConstants()) as $node) {
305302
foreach ($this->getInvalidXrefs($node->getContent()) as $invalidRef) {
306303
if (isset(self::$allowedReferenceFailures[$node->getFullname()])

dev/src/DocFx/Node/ClassNode.php

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -70,11 +70,6 @@ public function isProtobufMessageClass(): bool
7070
return false;
7171
}
7272

73-
public function isProtobufLibrary(): bool
74-
{
75-
return 0 === strpos($this->getNamespace(), '\Google\Protobuf');
76-
}
77-
7873
public function isGapicEnumClass(): bool
7974
{
8075
// returns true if the class extends \Google\Protobuf\Internal\Message

0 commit comments

Comments
 (0)