Skip to content

Commit a1b1b4a

Browse files
committed
fix pcntl tests and cs
1 parent 60060cc commit a1b1b4a

3 files changed

Lines changed: 9 additions & 14 deletions

File tree

Core/src/Testing/System/SystemTestCase.php

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@
2828
use Google\Cloud\Storage\StorageClient;
2929
use Google\Cloud\Core\Testing\System\DeletionQueue;
3030
use PHPUnit\Framework\TestCase;
31-
use Symfony\Component\Cache\Adapter\FilesystemAdapter;
3231

3332
/**
3433
* SystemTestCase can be extended to implement system tests
@@ -287,11 +286,4 @@ public static function skipIfEmulatorUsed($reason = null)
287286
self::markTestSkipped($reason ?: 'This test is not supported by the emulator.');
288287
}
289288
}
290-
291-
protected static function getCacheItemPool()
292-
{
293-
return new FilesystemAdapter(
294-
directory: __DIR__ . '/../../../../.cache'
295-
);
296-
}
297289
}

Spanner/tests/System/PgSystemTestCaseTrait.php

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?php
22
/**
3-
* Copyright 2022 Google Inc.
3+
* Copyright 2025 Google Inc.
44
*
55
* Licensed under the Apache License, Version 2.0 (the "License");
66
* you may not use this file except in compliance with the License.
@@ -19,10 +19,6 @@
1919

2020
use Google\Cloud\Spanner\Admin\Database\V1\DatabaseDialect;
2121

22-
/**
23-
* @group spanner
24-
* @group spanner-postgres
25-
*/
2622
trait PgSystemTestCaseTrait
2723
{
2824
use SystemTestCaseTrait;

Spanner/tests/System/SystemTestCaseTrait.php

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
use Google\Cloud\Spanner\SpannerClient;
2424
use Google\Cloud\Spanner\V1\Client\SpannerClient as SpannerGapicClient;
2525
use Google\Cloud\Spanner\Admin\Database\V1\DatabaseDialect;
26+
use Symfony\Component\Cache\Adapter\FilesystemAdapter;
2627

2728
trait SystemTestCaseTrait
2829
{
@@ -77,7 +78,7 @@ protected static function setUpTestDatabase(): void
7778
{
7879
if (self::$hasSetUp) {
7980
return;
80-
}
81+
}
8182

8283
self::$instance = self::getClient()->instance(self::INSTANCE_NAME);
8384

@@ -172,4 +173,10 @@ private static function getDatabaseFromInstance($instance, $dbName, $options = [
172173
return $instance->database($dbName, $options);
173174
}
174175

176+
protected static function getCacheItemPool()
177+
{
178+
return new FilesystemAdapter(
179+
directory: __DIR__ . '/../../../.cache'
180+
);
181+
}
175182
}

0 commit comments

Comments
 (0)