test(spanner): avoid ID collisions by using self::randId() with a larger range

Author: cy-yun

Core/src/Testing/System/SystemTestCase.php

@@ -76,7 +76,7 @@ public static function processQueue()
      */
     public static function randId()
     {
-        return rand(1, 9999999);
+        return rand(1, 999999999);
     }
 
     /**

Spanner/tests/System/PgTransactionTest.php

@@ -51,7 +51,7 @@ public static function setUpTestFixtures(): void
         }
         self::setUpTestDatabase();
 
-        self::$id1 = rand(1000, 9999);
+        self::$id1 = self::randId();
         self::$row = [
             'id' => self::$id1,
             'name' => uniqid(self::TESTING_PREFIX),
@@ -67,7 +67,7 @@ public function testRunTransaction()
         $db = self::$database;
 
         $db->runTransaction(function ($t) {
-            $id = rand(1, 346464);
+            $id = self::randId();
             $t->insertOrUpdate(self::TEST_TABLE_NAME, [
                 'id' => $id,
                 'name' => uniqid(self::TESTING_PREFIX),
@@ -146,7 +146,7 @@ public function testRunTransactionWithDbRole($db, $values, $expected)
 
         try {
             $db->runTransaction(function ($t) use ($values) {
-                $id = rand(1, 346464);
+                $id = self::randId();
                 $t->insert(self::TEST_TABLE_NAME, $values);
 
                 $t->commit();

Spanner/tests/System/TransactionTest.php

@@ -58,7 +58,7 @@ public static function setUpTestFixtures(): void
         }
         self::setUpTestDatabase();
 
-        self::$id1 = rand(1000, 9999);
+        self::$id1 = self::randId();
 
         self::$row = [
             'id' => self::$id1,
@@ -74,7 +74,7 @@ public static function setUpTestFixtures(): void
     public function testRunTransaction()
     {
         $db = self::$database;
-        $id = rand(1, 346464);
+        $id = self::randId();
         $keySet = new KeySet([
             'keys' => [$id]
         ]);
@@ -278,7 +278,7 @@ public function testRunTransactionWithDbRole($db, $values, $expected)
 
         try {
             $db->runTransaction(function ($t) use ($values) {
-                $id = rand(1, 346464);
+                $id = self::randId();
                 $t->insert(self::TEST_TABLE_NAME, $values);
 
                 $t->commit();
@@ -405,7 +405,7 @@ public function testRunTransactionILBWithMultipleOperations()
         $db = self::$database;
 
         $res = $db->runTransaction(function ($t) {
-            $id = rand(1, 346464);
+            $id = self::randId();
             $row = [
                 'id' => $id,
                 'name' => uniqid(self::TESTING_PREFIX),
@@ -415,7 +415,7 @@ public function testRunTransactionILBWithMultipleOperations()
             $t->insert(self::TEST_TABLE_NAME, $row);
             $this->assertNull($t->id());
 
-            $id = rand(1, 346464);
+            $id = self::randId();
             $t->executeUpdate(
                 'INSERT INTO ' . self::TEST_TABLE_NAME . ' (id, name, birthday) VALUES (@id, @name, @birthday)',
                 [
@@ -489,7 +489,7 @@ public function testTransactionToChannelAffinity()
         };
 
         $res = $db->runTransaction(function ($t) use ($getChannel) {
-            $id = rand(1, 346464);
+            $id = self::randId();
             $row = [
                 'id' => $id,
                 'name' => uniqid(self::TESTING_PREFIX),
@@ -499,7 +499,7 @@ public function testTransactionToChannelAffinity()
             $t->insert(self::TEST_TABLE_NAME, $row);
             $this->assertNull($t->id());
 
-            $id = rand(1, 346464);
+            $id = self::randId();
             $t->executeUpdate(
                 'INSERT INTO ' . self::TEST_TABLE_NAME . ' (id, name, birthday) VALUES (@id, @name, @birthday)',
                 [
@@ -677,7 +677,7 @@ private function getMultipleRows(int $total)
         // if $total is 10, then we will generate 9 rows.
         for ($i = 0; $i < $total; $i++) {
             $rows[] = [
-                'id' => rand(1, 346464),
+                'id' => self::randId(),
                 'name' => uniqid(self::TESTING_PREFIX),
                 'birthday' => new Date(new \DateTime('2000-01-01'))
             ];