Skip to content

Chore: Update move logic now to support non-HNS buckets #8705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bshaffer merged 3 commits into from
Nov 14, 2025
Merged

Chore: Update move logic now to support non-HNS buckets #8705

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7aeed16
Chore: Update move logic now to support non-HNS buckets
thiyaguk09 Oct 30, 2025
425adfc
Merge branch 'googleapis:main' into refactor/move-object
thiyaguk09 Nov 11, 2025
f559d25
Enhance test scenario
thiyaguk09 Nov 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Storage/src/StorageObject.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -478,7 +478,7 @@ public function rewrite($destination, array $options = [])
}

/**
* Move an object within a bucket with HNS enabled.
* Move an object within a bucket.
*
* This method copies data using multiple requests so large objects can be
* copied with a normal length timeout per request rather than one very long
Expand Down
3 changes: 1 addition & 2 deletions Storage/tests/System/ManageObjectsTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,7 +366,6 @@ public function testMoveObject()
self::$client,
$name,
[
'hierarchicalNamespace' => ['enabled' => true,],
Comment thread
thiyaguk09 marked this conversation as resolved.
'iamConfiguration' => ['uniformBucketLevelAccess' => ['enabled' => true]]
]
);
Expand All @@ -380,7 +379,7 @@ public function testMoveObject()
// Move the object.
$movedObject = $object->move($destinationObjectName);

// Assert that check existance of source and destination object.
// Assert that check existence of source and destination object.
$this->assertStorageObjectNotExists($sourceBucket, $object);
$this->assertStorageObjectExists($sourceBucket, $movedObject);
}
Expand Down