Skip to content

Commit 0b85e09

Browse files
committed
revert changes for pubsub and spanner
1 parent bef8d8a commit 0b85e09

13 files changed

Lines changed: 36 additions & 192 deletions

File tree

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
[mypy]
2+
python_version = 3.14
3+
namespace_packages = True
4+
ignore_missing_imports = False
5+
6+
# TODO(https://github.com/googleapis/gapic-generator-python/issues/2563):
7+
# Dependencies that historically lacks py.typed markers
8+
[mypy-google.iam.*]
9+
ignore_missing_imports = True
10+
11+
# Helps mypy navigate the 'google' namespace more reliably in 3.10+
12+
explicit_package_bases = True
13+
14+
# Performance: reuse results from previous runs to speed up 'nox'
15+
incremental = True

packages/google-cloud-pubsub/noxfile.py

Lines changed: 5 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -36,24 +36,16 @@
3636
"3.12",
3737
"3.13",
3838
"3.14",
39-
"3.15",
4039
]
4140

4241
DEFAULT_PYTHON_VERSION = "3.14"
4342

44-
PREVIEW_PYTHON_VERSION = "3.15"
43+
# TODO(https://github.com/googleapis/gapic-generator-python/issues/2450):
44+
# Switch this to Python 3.15 alpha1
45+
# https://peps.python.org/pep-0790/
46+
PREVIEW_PYTHON_VERSION = "3.14"
4547

4648
CURRENT_DIRECTORY = pathlib.Path(__file__).parent.absolute()
47-
# Path to the centralized mypy configuration file at the repository root.
48-
# Search upwards to support running nox from both monorepo packages and integration test goldens.
49-
MYPY_CONFIG_FILE = next(
50-
(
51-
str(p / "mypy.ini")
52-
for p in CURRENT_DIRECTORY.parents
53-
if (p / "mypy.ini").exists()
54-
),
55-
str(CURRENT_DIRECTORY.parent.parent / "mypy.ini"),
56-
)
5749

5850
if (CURRENT_DIRECTORY / "testing").exists():
5951
LOWER_BOUND_CONSTRAINTS_FILE = (
@@ -623,7 +615,7 @@ def prerelease_deps(session, protobuf_implementation):
623615
)
624616

625617

626-
@nox.session(python=PREVIEW_PYTHON_VERSION)
618+
@nox.session(python=DEFAULT_PYTHON_VERSION)
627619
@nox.parametrize(
628620
"protobuf_implementation",
629621
["python", "upb"],

packages/google-cloud-pubsub/testing/constraints-3.15.txt

Lines changed: 0 additions & 13 deletions
This file was deleted.

packages/google-cloud-pubsub/tests/unit/gapic/pubsub_v1/test_publisher.py

Lines changed: 0 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -3000,9 +3000,6 @@ def test_list_topics_pager(transport_name: str = "grpc"):
30003000
assert pager._retry == retry
30013001
assert pager._timeout == timeout
30023002

3003-
assert pager.next_page_token == "abc"
3004-
assert str(pager).startswith(f"{pager.__class__.__name__}<")
3005-
30063003
results = list(pager)
30073004
assert len(results) == 6
30083005
assert all(isinstance(i, pubsub.Topic) for i in results)
@@ -3091,8 +3088,6 @@ async def test_list_topics_async_pager():
30913088
request={},
30923089
)
30933090
assert async_pager.next_page_token == "abc"
3094-
assert str(async_pager).startswith(f"{async_pager.__class__.__name__}<")
3095-
30963091
responses = []
30973092
async for response in async_pager: # pragma: no branch
30983093
responses.append(response)
@@ -3550,9 +3545,6 @@ def test_list_topic_subscriptions_pager(transport_name: str = "grpc"):
35503545
assert pager._retry == retry
35513546
assert pager._timeout == timeout
35523547

3553-
assert pager.next_page_token == "abc"
3554-
assert str(pager).startswith(f"{pager.__class__.__name__}<")
3555-
35563548
results = list(pager)
35573549
assert len(results) == 6
35583550
assert all(isinstance(i, str) for i in results)
@@ -3645,8 +3637,6 @@ async def test_list_topic_subscriptions_async_pager():
36453637
request={},
36463638
)
36473639
assert async_pager.next_page_token == "abc"
3648-
assert str(async_pager).startswith(f"{async_pager.__class__.__name__}<")
3649-
36503640
responses = []
36513641
async for response in async_pager: # pragma: no branch
36523642
responses.append(response)
@@ -4103,9 +4093,6 @@ def test_list_topic_snapshots_pager(transport_name: str = "grpc"):
41034093
assert pager._retry == retry
41044094
assert pager._timeout == timeout
41054095

4106-
assert pager.next_page_token == "abc"
4107-
assert str(pager).startswith(f"{pager.__class__.__name__}<")
4108-
41094096
results = list(pager)
41104097
assert len(results) == 6
41114098
assert all(isinstance(i, str) for i in results)
@@ -4198,8 +4185,6 @@ async def test_list_topic_snapshots_async_pager():
41984185
request={},
41994186
)
42004187
assert async_pager.next_page_token == "abc"
4201-
assert str(async_pager).startswith(f"{async_pager.__class__.__name__}<")
4202-
42034188
responses = []
42044189
async for response in async_pager: # pragma: no branch
42054190
responses.append(response)
@@ -5773,9 +5758,6 @@ def test_list_topics_rest_pager(transport: str = "rest"):
57735758

57745759
pager = client.list_topics(request=sample_request)
57755760

5776-
assert pager.next_page_token == "abc"
5777-
assert str(pager).startswith(f"{pager.__class__.__name__}<")
5778-
57795761
results = list(pager)
57805762
assert len(results) == 6
57815763
assert all(isinstance(i, pubsub.Topic) for i in results)
@@ -6036,9 +6018,6 @@ def test_list_topic_subscriptions_rest_pager(transport: str = "rest"):
60366018

60376019
pager = client.list_topic_subscriptions(request=sample_request)
60386020

6039-
assert pager.next_page_token == "abc"
6040-
assert str(pager).startswith(f"{pager.__class__.__name__}<")
6041-
60426021
results = list(pager)
60436022
assert len(results) == 6
60446023
assert all(isinstance(i, str) for i in results)
@@ -6296,9 +6275,6 @@ def test_list_topic_snapshots_rest_pager(transport: str = "rest"):
62966275

62976276
pager = client.list_topic_snapshots(request=sample_request)
62986277

6299-
assert pager.next_page_token == "abc"
6300-
assert str(pager).startswith(f"{pager.__class__.__name__}<")
6301-
63026278
results = list(pager)
63036279
assert len(results) == 6
63046280
assert all(isinstance(i, str) for i in results)

packages/google-cloud-pubsub/tests/unit/gapic/pubsub_v1/test_schema_service.py

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -2390,9 +2390,6 @@ def test_list_schemas_pager(transport_name: str = "grpc"):
23902390
assert pager._retry == retry
23912391
assert pager._timeout == timeout
23922392

2393-
assert pager.next_page_token == "abc"
2394-
assert str(pager).startswith(f"{pager.__class__.__name__}<")
2395-
23962393
results = list(pager)
23972394
assert len(results) == 6
23982395
assert all(isinstance(i, schema.Schema) for i in results)
@@ -2481,8 +2478,6 @@ async def test_list_schemas_async_pager():
24812478
request={},
24822479
)
24832480
assert async_pager.next_page_token == "abc"
2484-
assert str(async_pager).startswith(f"{async_pager.__class__.__name__}<")
2485-
24862481
responses = []
24872482
async for response in async_pager: # pragma: no branch
24882483
responses.append(response)
@@ -2934,9 +2929,6 @@ def test_list_schema_revisions_pager(transport_name: str = "grpc"):
29342929
assert pager._retry == retry
29352930
assert pager._timeout == timeout
29362931

2937-
assert pager.next_page_token == "abc"
2938-
assert str(pager).startswith(f"{pager.__class__.__name__}<")
2939-
29402932
results = list(pager)
29412933
assert len(results) == 6
29422934
assert all(isinstance(i, schema.Schema) for i in results)
@@ -3029,8 +3021,6 @@ async def test_list_schema_revisions_async_pager():
30293021
request={},
30303022
)
30313023
assert async_pager.next_page_token == "abc"
3032-
assert str(async_pager).startswith(f"{async_pager.__class__.__name__}<")
3033-
30343024
responses = []
30353025
async for response in async_pager: # pragma: no branch
30363026
responses.append(response)
@@ -5625,9 +5615,6 @@ def test_list_schemas_rest_pager(transport: str = "rest"):
56255615

56265616
pager = client.list_schemas(request=sample_request)
56275617

5628-
assert pager.next_page_token == "abc"
5629-
assert str(pager).startswith(f"{pager.__class__.__name__}<")
5630-
56315618
results = list(pager)
56325619
assert len(results) == 6
56335620
assert all(isinstance(i, schema.Schema) for i in results)
@@ -5890,9 +5877,6 @@ def test_list_schema_revisions_rest_pager(transport: str = "rest"):
58905877

58915878
pager = client.list_schema_revisions(request=sample_request)
58925879

5893-
assert pager.next_page_token == "abc"
5894-
assert str(pager).startswith(f"{pager.__class__.__name__}<")
5895-
58965880
results = list(pager)
58975881
assert len(results) == 6
58985882
assert all(isinstance(i, schema.Schema) for i in results)

packages/google-cloud-pubsub/tests/unit/gapic/pubsub_v1/test_subscriber.py

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -2824,9 +2824,6 @@ def test_list_subscriptions_pager(transport_name: str = "grpc"):
28242824
assert pager._retry == retry
28252825
assert pager._timeout == timeout
28262826

2827-
assert pager.next_page_token == "abc"
2828-
assert str(pager).startswith(f"{pager.__class__.__name__}<")
2829-
28302827
results = list(pager)
28312828
assert len(results) == 6
28322829
assert all(isinstance(i, pubsub.Subscription) for i in results)
@@ -2919,8 +2916,6 @@ async def test_list_subscriptions_async_pager():
29192916
request={},
29202917
)
29212918
assert async_pager.next_page_token == "abc"
2922-
assert str(async_pager).startswith(f"{async_pager.__class__.__name__}<")
2923-
29242919
responses = []
29252920
async for response in async_pager: # pragma: no branch
29262921
responses.append(response)
@@ -5495,9 +5490,6 @@ def test_list_snapshots_pager(transport_name: str = "grpc"):
54955490
assert pager._retry == retry
54965491
assert pager._timeout == timeout
54975492

5498-
assert pager.next_page_token == "abc"
5499-
assert str(pager).startswith(f"{pager.__class__.__name__}<")
5500-
55015493
results = list(pager)
55025494
assert len(results) == 6
55035495
assert all(isinstance(i, pubsub.Snapshot) for i in results)
@@ -5586,8 +5578,6 @@ async def test_list_snapshots_async_pager():
55865578
request={},
55875579
)
55885580
assert async_pager.next_page_token == "abc"
5589-
assert str(async_pager).startswith(f"{async_pager.__class__.__name__}<")
5590-
55915581
responses = []
55925582
async for response in async_pager: # pragma: no branch
55935583
responses.append(response)
@@ -7663,9 +7653,6 @@ def test_list_subscriptions_rest_pager(transport: str = "rest"):
76637653

76647654
pager = client.list_subscriptions(request=sample_request)
76657655

7666-
assert pager.next_page_token == "abc"
7667-
assert str(pager).startswith(f"{pager.__class__.__name__}<")
7668-
76697656
results = list(pager)
76707657
assert len(results) == 6
76717658
assert all(isinstance(i, pubsub.Subscription) for i in results)
@@ -9043,9 +9030,6 @@ def test_list_snapshots_rest_pager(transport: str = "rest"):
90439030

90449031
pager = client.list_snapshots(request=sample_request)
90459032

9046-
assert pager.next_page_token == "abc"
9047-
assert str(pager).startswith(f"{pager.__class__.__name__}<")
9048-
90499033
results = list(pager)
90509034
assert len(results) == 6
90519035
assert all(isinstance(i, pubsub.Snapshot) for i in results)
Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
[mypy]
2+
python_version = 3.14
3+
namespace_packages = True
4+
ignore_missing_imports = False
5+
6+
# TODO(https://github.com/googleapis/gapic-generator-python/issues/2563):
7+
# Dependencies that historically lacks py.typed markers
8+
[mypy-google.iam.*]
9+
ignore_missing_imports = True
10+
11+
# Helps mypy navigate the 'google' namespace more reliably in 3.10+
12+
explicit_package_bases = True
13+
14+
# Performance: reuse results from previous runs to speed up 'nox'
15+
incremental = True

packages/google-cloud-spanner/testing/constraints-3.15.txt

Lines changed: 0 additions & 12 deletions
This file was deleted.

packages/google-cloud-spanner/tests/system/_helpers.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,9 @@
1818
import uuid
1919

2020
from google.api_core import datetime_helpers, exceptions
21+
from google.cloud.spanner_v1 import instance as instance_mod
2122
from test_utils import retry
2223

23-
from google.cloud.spanner_v1 import instance as instance_mod
2424
from tests import _fixtures
2525

2626
CREATE_INSTANCE_ENVVAR = "GOOGLE_CLOUD_TESTS_CREATE_SPANNER_INSTANCE"

packages/google-cloud-spanner/tests/system/conftest.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
import time
1818

1919
import pytest
20-
2120
from google.cloud import spanner_v1
2221
from google.cloud.spanner_admin_database_v1 import DatabaseDialect
2322
from google.cloud.spanner_admin_database_v1.types.backup import (

0 commit comments

Comments
 (0)