Skip to content

Commit 0b9344e

Browse files
authored
chore(actions): fix template injection zizmor findings (#17612)
This addresses some remaining zizmor findings for template injection. Results: ```bash $ zizmor --gh-token=$(gh auth token) ./.github/workflows INFO zizmor: 🌈 zizmor v1.25.2 INFO audit: zizmor: 🌈 completed ./.github/workflows/bigframes-docs-deploy.yaml INFO audit: zizmor: 🌈 completed ./.github/workflows/bigtable-conformance.yaml INFO audit: zizmor: 🌈 completed ./.github/workflows/django-spanner-django5.2_tests.yml INFO audit: zizmor: 🌈 completed ./.github/workflows/django-spanner-foreign_keys.yaml INFO audit: zizmor: 🌈 completed ./.github/workflows/django-spanner-integration-tests-against-emulator-3.10.yml INFO audit: zizmor: 🌈 completed ./.github/workflows/django-spanner-mockserver-tests.yml INFO audit: zizmor: 🌈 completed ./.github/workflows/docs.yml INFO audit: zizmor: 🌈 completed ./.github/workflows/gapic-generator-tests.yml INFO audit: zizmor: 🌈 completed ./.github/workflows/librarian_tidy.yml INFO audit: zizmor: 🌈 completed ./.github/workflows/lint.yml INFO audit: zizmor: 🌈 completed ./.github/workflows/main.yml INFO audit: zizmor: 🌈 completed ./.github/workflows/regenerate-all.yml INFO audit: zizmor: 🌈 completed ./.github/workflows/unittest.yml INFO audit: zizmor: 🌈 completed ./.github/workflows/version_scanner.yml No findings to report. Good job! (9 ignored, 50 suppressed) ```
1 parent bbcf902 commit 0b9344e

1 file changed

Lines changed: 5 additions & 2 deletions

File tree

.github/workflows/gapic-generator-tests.yml

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -135,11 +135,13 @@ jobs:
135135
- name: Install System Deps
136136
run: sudo apt-get update && sudo apt-get install -y pandoc
137137
- name: Run Goldens
138+
env:
139+
LATEST_STABLE_PYTHON: ${{ needs.python_config.outputs.latest_stable_python }}
138140
run: |
139141
pip install nox
140142
cd packages/gapic-generator
141143
for pkg in credentials eventarc logging redis; do
142-
nox -f tests/integration/goldens/$pkg/noxfile.py -s format lint unit-${{ needs.python_config.outputs.latest_stable_python }}
144+
nox -f tests/integration/goldens/$pkg/noxfile.py -s format lint unit-${LATEST_STABLE_PYTHON}
143145
done
144146
# Run pylint (errors-only) over the goldens so generator regressions
145147
# like undefined names or import-time breakage that ruff/flake8 do
@@ -214,11 +216,12 @@ jobs:
214216
# Run fragment for current matrix python
215217
nox -s fragment-${MATRIX_PYTHON}
216218
# Run snippetgen only on the latest stable to avoid the "Python not found" error
217-
if [ "${MATRIX_PYTHON}" == "${{ needs.python_config.outputs.latest_stable_python }}" ]; then
219+
if [ "${MATRIX_PYTHON}" == "${LATEST_STABLE_PYTHON}" ]; then
218220
nox -s snippetgen
219221
fi
220222
env:
221223
MATRIX_PYTHON: ${{ matrix.python }}
224+
LATEST_STABLE_PYTHON: ${{ needs.python_config.outputs.latest_stable_python }}
222225
integration:
223226
needs: python_config
224227
# Only runs if the Gatekeeper passed

0 commit comments

Comments
 (0)