remove system_time

Author: chelsea-lin

packages/bigframes/tests/unit/core/compile/sqlglot/tpch/conftest.py

@@ -13,15 +13,21 @@
 # limitations under the License.
 
 import datetime
+import functools
 import unittest.mock as mock
 
 import pytest
 from google.cloud import bigquery
 
 import bigframes.testing.mocks as mocks
+from bigframes.testing import compiler_session
 
 freezegun = pytest.importorskip("freezegun")
 
+PROJECT_NAME = "bigframes-dev-perf"
+DATASET_NAME = "tpch_0001t"
+LOCATION_NAME = "test-region"
+
 TPCH_SCHEMAS = {
     "LINEITEM": [
         bigquery.SchemaField("L_ORDERKEY", "INTEGER", mode="REQUIRED"),
@@ -102,49 +108,57 @@
     ],
 }
 
+def _create_mock_bqclient():
+    """Helper function to create a compiler session."""
+
+    bqclient = mock.create_autospec(bigquery.Client, instance=True)
+    bqclient.project = DATASET_NAME
+    bqclient.location = LOCATION_NAME
+
+    def get_table_mock(table_ref):
+        if isinstance(table_ref, str):
+            table_ref = bigquery.TableReference.from_string(table_ref)
+
+        table_id = table_ref.table_id
+        schema = TPCH_SCHEMAS.get(table_id, [])
+
+        table = mock.create_autospec(bigquery.Table, instance=True)
+        table._properties = {}
+        # mocks.create_bigquery_session's CURRENT_TIMESTAMP() returns offset-naive datetime.now()
+        # So we should also use offset-naive here to avoid comparison errors.
+        type(table).created = mock.PropertyMock(return_value=datetime.datetime.now())
+        type(table).location = mock.PropertyMock(return_value=LOCATION_NAME)
+        type(table).schema = mock.PropertyMock(return_value=schema)
+        type(table).project = table_ref.project
+        type(table).dataset_id = table_ref.dataset_id
+        type(table).table_id = table_id
+        type(table).num_rows = mock.PropertyMock(return_value=1000000000)
+        return table
+
+    bqclient.get_table.side_effect = get_table_mock
+    return bqclient
+
 
 @pytest.fixture(scope="session")
 def tpch_session():
-    from bigframes.testing import compiler_session
 
     anonymous_dataset = bigquery.DatasetReference.from_string(
-        "bigframes-dev-perf.tpch_0001t"
+        f"{PROJECT_NAME}.{DATASET_NAME}"
+    )
+    session = mocks.create_bigquery_session(
+        bqclient = _create_mock_bqclient(),
+        anonymous_dataset=anonymous_dataset,
     )
-    location = "us-central1"
-
-    with freezegun.freeze_time("2026-04-05 18:00:00"):
-        session = mocks.create_bigquery_session(
-            anonymous_dataset=anonymous_dataset,
-            location=location,
-        )
-
-        def get_table_mock(table_ref):
-            if isinstance(table_ref, str):
-                table_ref = bigquery.TableReference.from_string(table_ref)
-
-            table_id = table_ref.table_id
-            schema = TPCH_SCHEMAS.get(table_id, [])
-
-            table = mock.create_autospec(bigquery.Table, instance=True)
-            table._properties = {}
-            # mocks.create_bigquery_session's CURRENT_TIMESTAMP() returns offset-naive datetime.now()
-            # So we should also use offset-naive here to avoid comparison errors.
-            now = datetime.datetime.now()
-            type(table).schema = mock.PropertyMock(return_value=schema)
-            type(table).project = table_ref.project
-            type(table).dataset_id = table_ref.dataset_id
-            type(table).table_id = table_id
-            type(table).num_rows = mock.PropertyMock(return_value=1000000)
-            type(table).num_bytes = mock.PropertyMock(return_value=1000000)
-            type(table).location = mock.PropertyMock(return_value=location)
-            type(table).table_type = mock.PropertyMock(return_value="TABLE")
-            type(table).created = mock.PropertyMock(return_value=now)
-            type(table).modified = mock.PropertyMock(return_value=now)
-            type(table).range_partitioning = mock.PropertyMock(return_value=None)
-            type(table).time_partitioning = mock.PropertyMock(return_value=None)
-            type(table).clustering_fields = mock.PropertyMock(return_value=None)
-            return table
-
-        session.bqclient.get_table.side_effect = get_table_mock
-        session._executor = compiler_session.SQLCompilerExecutor()
-        return session
+
+    # Disable snapshotting for TPC-H tests to keep snapshots clean of FOR SYSTEM_TIME AS OF
+    original_read_gbq_table = session._loader.read_gbq_table
+
+    @functools.wraps(original_read_gbq_table)
+    def read_gbq_table_no_snapshot(*args, **kwargs):
+        kwargs["enable_snapshot"] = False
+        return original_read_gbq_table(*args, **kwargs)
+
+    session._loader.read_gbq_table = read_gbq_table_no_snapshot
+
+    session._executor = compiler_session.SQLCompilerExecutor()
+    return session

packages/bigframes/tests/unit/core/compile/sqlglot/tpch/snapshots/test_tpch/test_tpch_query/1/out.sql

@@ -38,7 +38,7 @@ WITH `bfcte_0` AS (
     ) * (
       1.0 + `L_TAX`
     ) AS `bfcol_47`
-  FROM `bigframes-dev-perf`.`tpch_0001t`.`LINEITEM` AS `bft_0` FOR SYSTEM_TIME AS OF '2026-04-05T18:00:00'
+  FROM `bigframes-dev-perf`.`tpch_0001t`.`LINEITEM` AS `bft_0`
   WHERE
     `L_SHIPDATE` <= CAST('1998-09-02' AS DATE)
 ), `bfcte_1` AS (

packages/bigframes/tests/unit/core/compile/sqlglot/tpch/snapshots/test_tpch/test_tpch_query/10/out.sql

@@ -2,20 +2,20 @@ WITH `bfcte_0` AS (
   SELECT
     `N_NATIONKEY` AS `bfcol_0`,
     `N_NAME` AS `bfcol_1`
-  FROM `bigframes-dev-perf`.`tpch_0001t`.`NATION` AS `bft_3` FOR SYSTEM_TIME AS OF '2026-04-05T18:00:00'
+  FROM `bigframes-dev-perf`.`tpch_0001t`.`NATION` AS `bft_3`
 ), `bfcte_1` AS (
   SELECT
     `L_ORDERKEY` AS `bfcol_2`,
     `L_EXTENDEDPRICE` AS `bfcol_3`,
     `L_DISCOUNT` AS `bfcol_4`,
     `L_RETURNFLAG` AS `bfcol_5`
-  FROM `bigframes-dev-perf`.`tpch_0001t`.`LINEITEM` AS `bft_2` FOR SYSTEM_TIME AS OF '2026-04-05T18:00:00'
+  FROM `bigframes-dev-perf`.`tpch_0001t`.`LINEITEM` AS `bft_2`
 ), `bfcte_2` AS (
   SELECT
     `O_ORDERKEY` AS `bfcol_6`,
     `O_CUSTKEY` AS `bfcol_7`,
     `O_ORDERDATE` AS `bfcol_8`
-  FROM `bigframes-dev-perf`.`tpch_0001t`.`ORDERS` AS `bft_1` FOR SYSTEM_TIME AS OF '2026-04-05T18:00:00'
+  FROM `bigframes-dev-perf`.`tpch_0001t`.`ORDERS` AS `bft_1`
 ), `bfcte_3` AS (
   SELECT
     `C_CUSTKEY` AS `bfcol_9`,
@@ -25,7 +25,7 @@ WITH `bfcte_0` AS (
     `C_PHONE` AS `bfcol_13`,
     `C_ACCTBAL` AS `bfcol_14`,
     `C_COMMENT` AS `bfcol_15`
-  FROM `bigframes-dev-perf`.`tpch_0001t`.`CUSTOMER` AS `bft_0` FOR SYSTEM_TIME AS OF '2026-04-05T18:00:00'
+  FROM `bigframes-dev-perf`.`tpch_0001t`.`CUSTOMER` AS `bft_0`
 ), `bfcte_4` AS (
   SELECT
     `bfcol_9` AS `bfcol_16`,

packages/bigframes/tests/unit/core/compile/sqlglot/tpch/snapshots/test_tpch/test_tpch_query/11/out.sql

@@ -7,23 +7,23 @@ WITH `bfcte_0` AS (
     `PS_SUPPKEY` AS `bfcol_0`,
     `PS_AVAILQTY` AS `bfcol_1`,
     `PS_SUPPLYCOST` AS `bfcol_2`
-  FROM `bigframes-dev-perf`.`tpch_0001t`.`PARTSUPP` AS `bft_2` FOR SYSTEM_TIME AS OF '2026-04-05T18:00:00'
+  FROM `bigframes-dev-perf`.`tpch_0001t`.`PARTSUPP` AS `bft_2`
 ), `bfcte_2` AS (
   SELECT
     `PS_PARTKEY` AS `bfcol_10`,
     `PS_SUPPKEY` AS `bfcol_11`,
     `PS_AVAILQTY` AS `bfcol_12`,
     `PS_SUPPLYCOST` AS `bfcol_13`
-  FROM `bigframes-dev-perf`.`tpch_0001t`.`PARTSUPP` AS `bft_2` FOR SYSTEM_TIME AS OF '2026-04-05T18:00:00'
+  FROM `bigframes-dev-perf`.`tpch_0001t`.`PARTSUPP` AS `bft_2`
 ), `bfcte_3` AS (
   SELECT
     `S_SUPPKEY` AS `bfcol_3`,
     `S_NATIONKEY` AS `bfcol_4`
-  FROM `bigframes-dev-perf`.`tpch_0001t`.`SUPPLIER` AS `bft_1` FOR SYSTEM_TIME AS OF '2026-04-05T18:00:00'
+  FROM `bigframes-dev-perf`.`tpch_0001t`.`SUPPLIER` AS `bft_1`
 ), `bfcte_4` AS (
   SELECT
     `N_NATIONKEY` AS `bfcol_18`
-  FROM `bigframes-dev-perf`.`tpch_0001t`.`NATION` AS `bft_0` FOR SYSTEM_TIME AS OF '2026-04-05T18:00:00'
+  FROM `bigframes-dev-perf`.`tpch_0001t`.`NATION` AS `bft_0`
   WHERE
     `N_NAME` = 'GERMANY'
 ), `bfcte_5` AS (

packages/bigframes/tests/unit/core/compile/sqlglot/tpch/snapshots/test_tpch/test_tpch_query/12/out.sql

@@ -5,12 +5,12 @@ WITH `bfcte_0` AS (
     `L_COMMITDATE` AS `bfcol_2`,
     `L_RECEIPTDATE` AS `bfcol_3`,
     `L_SHIPMODE` AS `bfcol_4`
-  FROM `bigframes-dev-perf`.`tpch_0001t`.`LINEITEM` AS `bft_1` FOR SYSTEM_TIME AS OF '2026-04-05T18:00:00'
+  FROM `bigframes-dev-perf`.`tpch_0001t`.`LINEITEM` AS `bft_1`
 ), `bfcte_1` AS (
   SELECT
     `O_ORDERKEY` AS `bfcol_5`,
     `O_ORDERPRIORITY` AS `bfcol_6`
-  FROM `bigframes-dev-perf`.`tpch_0001t`.`ORDERS` AS `bft_0` FOR SYSTEM_TIME AS OF '2026-04-05T18:00:00'
+  FROM `bigframes-dev-perf`.`tpch_0001t`.`ORDERS` AS `bft_0`
 ), `bfcte_2` AS (
   SELECT
     `bfcol_5`,

packages/bigframes/tests/unit/core/compile/sqlglot/tpch/snapshots/test_tpch/test_tpch_query/13/out.sql

@@ -2,15 +2,15 @@ WITH `bfcte_0` AS (
   SELECT
     `O_ORDERKEY` AS `bfcol_10`,
     `O_CUSTKEY` AS `bfcol_11`
-  FROM `bigframes-dev-perf`.`tpch_0001t`.`ORDERS` AS `bft_1` FOR SYSTEM_TIME AS OF '2026-04-05T18:00:00'
+  FROM `bigframes-dev-perf`.`tpch_0001t`.`ORDERS` AS `bft_1`
   WHERE
     NOT (
       REGEXP_CONTAINS(`O_COMMENT`, 'special.*requests')
     )
 ), `bfcte_1` AS (
   SELECT
     `C_CUSTKEY` AS `bfcol_3`
-  FROM `bigframes-dev-perf`.`tpch_0001t`.`CUSTOMER` AS `bft_0` FOR SYSTEM_TIME AS OF '2026-04-05T18:00:00'
+  FROM `bigframes-dev-perf`.`tpch_0001t`.`CUSTOMER` AS `bft_0`
 ), `bfcte_2` AS (
   SELECT
     `bfcol_3`,

packages/bigframes/tests/unit/core/compile/sqlglot/tpch/snapshots/test_tpch/test_tpch_query/14/out.sql

@@ -12,16 +12,16 @@ WITH `bfcte_0` AS (
     `L_EXTENDEDPRICE` AS `bfcol_1`,
     `L_DISCOUNT` AS `bfcol_2`,
     `L_SHIPDATE` AS `bfcol_3`
-  FROM `bigframes-dev-perf`.`tpch_0001t`.`LINEITEM` AS `bft_1` FOR SYSTEM_TIME AS OF '2026-04-05T18:00:00'
+  FROM `bigframes-dev-perf`.`tpch_0001t`.`LINEITEM` AS `bft_1`
 ), `bfcte_3` AS (
   SELECT
     `P_PARTKEY` AS `bfcol_4`
-  FROM `bigframes-dev-perf`.`tpch_0001t`.`PART` AS `bft_0` FOR SYSTEM_TIME AS OF '2026-04-05T18:00:00'
+  FROM `bigframes-dev-perf`.`tpch_0001t`.`PART` AS `bft_0`
 ), `bfcte_4` AS (
   SELECT
     `P_PARTKEY` AS `bfcol_8`,
     `P_TYPE` AS `bfcol_9`
-  FROM `bigframes-dev-perf`.`tpch_0001t`.`PART` AS `bft_0` FOR SYSTEM_TIME AS OF '2026-04-05T18:00:00'
+  FROM `bigframes-dev-perf`.`tpch_0001t`.`PART` AS `bft_0`
 ), `bfcte_5` AS (
   SELECT
     `bfcol_4`,

packages/bigframes/tests/unit/core/compile/sqlglot/tpch/snapshots/test_tpch/test_tpch_query/15/out.sql

@@ -21,7 +21,7 @@ WITH `bfcte_0` AS (
     `L_EXTENDEDPRICE` * (
       1 - `L_DISCOUNT`
     ) AS `bfcol_24`
-  FROM `bigframes-dev-perf`.`tpch_0001t`.`LINEITEM` AS `bft_1` FOR SYSTEM_TIME AS OF '2026-04-05T18:00:00'
+  FROM `bigframes-dev-perf`.`tpch_0001t`.`LINEITEM` AS `bft_1`
   WHERE
     (
       `L_SHIPDATE` >= CAST('1996-01-01' AS DATE)
@@ -32,14 +32,14 @@ WITH `bfcte_0` AS (
 ), `bfcte_2` AS (
   SELECT
     `S_SUPPKEY` AS `bfcol_4`
-  FROM `bigframes-dev-perf`.`tpch_0001t`.`SUPPLIER` AS `bft_0` FOR SYSTEM_TIME AS OF '2026-04-05T18:00:00'
+  FROM `bigframes-dev-perf`.`tpch_0001t`.`SUPPLIER` AS `bft_0`
 ), `bfcte_3` AS (
   SELECT
     `S_SUPPKEY` AS `bfcol_8`,
     `S_NAME` AS `bfcol_9`,
     `S_ADDRESS` AS `bfcol_10`,
     `S_PHONE` AS `bfcol_11`
-  FROM `bigframes-dev-perf`.`tpch_0001t`.`SUPPLIER` AS `bft_0` FOR SYSTEM_TIME AS OF '2026-04-05T18:00:00'
+  FROM `bigframes-dev-perf`.`tpch_0001t`.`SUPPLIER` AS `bft_0`
 ), `bfcte_4` AS (
   SELECT
     `bfcol_23`,

packages/bigframes/tests/unit/core/compile/sqlglot/tpch/snapshots/test_tpch/test_tpch_query/16/out.sql

@@ -6,7 +6,7 @@ WITH `bfcte_0` AS (
     NOT (
       REGEXP_CONTAINS(`S_COMMENT`, 'Customer.*Complaints')
     ) AS `bfcol_9`
-  FROM `bigframes-dev-perf`.`tpch_0001t`.`SUPPLIER` AS `bft_2` FOR SYSTEM_TIME AS OF '2026-04-05T18:00:00'
+  FROM `bigframes-dev-perf`.`tpch_0001t`.`SUPPLIER` AS `bft_2`
   WHERE
     NOT (
       REGEXP_CONTAINS(`S_COMMENT`, 'Customer.*Complaints')
@@ -15,14 +15,14 @@ WITH `bfcte_0` AS (
   SELECT
     `PS_PARTKEY` AS `bfcol_2`,
     `PS_SUPPKEY` AS `bfcol_3`
-  FROM `bigframes-dev-perf`.`tpch_0001t`.`PARTSUPP` AS `bft_1` FOR SYSTEM_TIME AS OF '2026-04-05T18:00:00'
+  FROM `bigframes-dev-perf`.`tpch_0001t`.`PARTSUPP` AS `bft_1`
 ), `bfcte_2` AS (
   SELECT
     `P_PARTKEY` AS `bfcol_4`,
     `P_BRAND` AS `bfcol_5`,
     `P_TYPE` AS `bfcol_6`,
     `P_SIZE` AS `bfcol_7`
-  FROM `bigframes-dev-perf`.`tpch_0001t`.`PART` AS `bft_0` FOR SYSTEM_TIME AS OF '2026-04-05T18:00:00'
+  FROM `bigframes-dev-perf`.`tpch_0001t`.`PART` AS `bft_0`
 ), `bfcte_3` AS (
   SELECT
     `bfcol_8`

packages/bigframes/tests/unit/core/compile/sqlglot/tpch/snapshots/test_tpch/test_tpch_query/17/out.sql

@@ -5,7 +5,7 @@ WITH `bfcte_0` AS (
 ), `bfcte_1` AS (
   SELECT
     `P_PARTKEY` AS `bfcol_15`
-  FROM `bigframes-dev-perf`.`tpch_0001t`.`PART` AS `bft_1` FOR SYSTEM_TIME AS OF '2026-04-05T18:00:00'
+  FROM `bigframes-dev-perf`.`tpch_0001t`.`PART` AS `bft_1`
   WHERE
     (
       `P_BRAND` = 'Brand#23'
@@ -17,12 +17,12 @@ WITH `bfcte_0` AS (
     `L_PARTKEY` AS `bfcol_3`,
     `L_QUANTITY` AS `bfcol_4`,
     `L_EXTENDEDPRICE` AS `bfcol_5`
-  FROM `bigframes-dev-perf`.`tpch_0001t`.`LINEITEM` AS `bft_0` FOR SYSTEM_TIME AS OF '2026-04-05T18:00:00'
+  FROM `bigframes-dev-perf`.`tpch_0001t`.`LINEITEM` AS `bft_0`
 ), `bfcte_3` AS (
   SELECT
     `L_PARTKEY` AS `bfcol_6`,
     `L_QUANTITY` AS `bfcol_7`
-  FROM `bigframes-dev-perf`.`tpch_0001t`.`LINEITEM` AS `bft_0` FOR SYSTEM_TIME AS OF '2026-04-05T18:00:00'
+  FROM `bigframes-dev-perf`.`tpch_0001t`.`LINEITEM` AS `bft_0`
 ), `bfcte_4` AS (
   SELECT
     `bfcol_4` AS `bfcol_16`,