Skip to content

Commit 1e6b56e

Browse files
committed
docs(generator): update TODO issue link to #17813 in _compat.py
1 parent 3e6b78c commit 1e6b56e

9 files changed

Lines changed: 9 additions & 9 deletions

File tree

  • packages/gapic-generator

packages/gapic-generator/gapic/templates/%namespace/%name_%version/%sub/_compat.py.j2

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import uuid
66
try:
77
from google.api_core.gapic_v1.requests import setup_request_id # type: ignore
88
except ImportError: # pragma: NO COVER
9-
# TODO(https://github.com/googleapis/google-cloud-python/issues/17812): Remove this fallback when google-api-core >= 2.26.0 is the minimum required version.
9+
# TODO(https://github.com/googleapis/google-cloud-python/issues/17813): Remove this fallback when google-api-core >= 2.26.0 is the minimum required version.
1010
def setup_request_id(request, field_name: str, is_proto3_optional: bool):
1111
"""Populate a UUID4 field in the request if it is not already set.
1212

packages/gapic-generator/tests/integration/goldens/asset/google/cloud/asset_v1/_compat.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
try:
2020
from google.api_core.gapic_v1.requests import setup_request_id # type: ignore
2121
except ImportError: # pragma: NO COVER
22-
# TODO(https://github.com/googleapis/google-cloud-python/issues/17812): Remove this fallback when google-api-core >= 2.26.0 is the minimum required version.
22+
# TODO(https://github.com/googleapis/google-cloud-python/issues/17813): Remove this fallback when google-api-core >= 2.26.0 is the minimum required version.
2323
def setup_request_id(request, field_name: str, is_proto3_optional: bool):
2424
"""Populate a UUID4 field in the request if it is not already set.
2525

packages/gapic-generator/tests/integration/goldens/credentials/google/iam/credentials_v1/_compat.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
try:
2020
from google.api_core.gapic_v1.requests import setup_request_id # type: ignore
2121
except ImportError: # pragma: NO COVER
22-
# TODO(https://github.com/googleapis/google-cloud-python/issues/17812): Remove this fallback when google-api-core >= 2.26.0 is the minimum required version.
22+
# TODO(https://github.com/googleapis/google-cloud-python/issues/17813): Remove this fallback when google-api-core >= 2.26.0 is the minimum required version.
2323
def setup_request_id(request, field_name: str, is_proto3_optional: bool):
2424
"""Populate a UUID4 field in the request if it is not already set.
2525

packages/gapic-generator/tests/integration/goldens/eventarc/google/cloud/eventarc_v1/_compat.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
try:
2020
from google.api_core.gapic_v1.requests import setup_request_id # type: ignore
2121
except ImportError: # pragma: NO COVER
22-
# TODO(https://github.com/googleapis/google-cloud-python/issues/17812): Remove this fallback when google-api-core >= 2.26.0 is the minimum required version.
22+
# TODO(https://github.com/googleapis/google-cloud-python/issues/17813): Remove this fallback when google-api-core >= 2.26.0 is the minimum required version.
2323
def setup_request_id(request, field_name: str, is_proto3_optional: bool):
2424
"""Populate a UUID4 field in the request if it is not already set.
2525

packages/gapic-generator/tests/integration/goldens/logging/google/cloud/logging_v2/_compat.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
try:
2020
from google.api_core.gapic_v1.requests import setup_request_id # type: ignore
2121
except ImportError: # pragma: NO COVER
22-
# TODO(https://github.com/googleapis/google-cloud-python/issues/17812): Remove this fallback when google-api-core >= 2.26.0 is the minimum required version.
22+
# TODO(https://github.com/googleapis/google-cloud-python/issues/17813): Remove this fallback when google-api-core >= 2.26.0 is the minimum required version.
2323
def setup_request_id(request, field_name: str, is_proto3_optional: bool):
2424
"""Populate a UUID4 field in the request if it is not already set.
2525

packages/gapic-generator/tests/integration/goldens/logging_internal/google/cloud/logging_v2/_compat.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
try:
2020
from google.api_core.gapic_v1.requests import setup_request_id # type: ignore
2121
except ImportError: # pragma: NO COVER
22-
# TODO(https://github.com/googleapis/google-cloud-python/issues/17812): Remove this fallback when google-api-core >= 2.26.0 is the minimum required version.
22+
# TODO(https://github.com/googleapis/google-cloud-python/issues/17813): Remove this fallback when google-api-core >= 2.26.0 is the minimum required version.
2323
def setup_request_id(request, field_name: str, is_proto3_optional: bool):
2424
"""Populate a UUID4 field in the request if it is not already set.
2525

packages/gapic-generator/tests/integration/goldens/redis/google/cloud/redis_v1/_compat.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
try:
2020
from google.api_core.gapic_v1.requests import setup_request_id # type: ignore
2121
except ImportError: # pragma: NO COVER
22-
# TODO(https://github.com/googleapis/google-cloud-python/issues/17812): Remove this fallback when google-api-core >= 2.26.0 is the minimum required version.
22+
# TODO(https://github.com/googleapis/google-cloud-python/issues/17813): Remove this fallback when google-api-core >= 2.26.0 is the minimum required version.
2323
def setup_request_id(request, field_name: str, is_proto3_optional: bool):
2424
"""Populate a UUID4 field in the request if it is not already set.
2525

packages/gapic-generator/tests/integration/goldens/redis_selective/google/cloud/redis_v1/_compat.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
try:
2020
from google.api_core.gapic_v1.requests import setup_request_id # type: ignore
2121
except ImportError: # pragma: NO COVER
22-
# TODO(https://github.com/googleapis/google-cloud-python/issues/17812): Remove this fallback when google-api-core >= 2.26.0 is the minimum required version.
22+
# TODO(https://github.com/googleapis/google-cloud-python/issues/17813): Remove this fallback when google-api-core >= 2.26.0 is the minimum required version.
2323
def setup_request_id(request, field_name: str, is_proto3_optional: bool):
2424
"""Populate a UUID4 field in the request if it is not already set.
2525

packages/gapic-generator/tests/integration/goldens/storagebatchoperations/google/cloud/storagebatchoperations_v1/_compat.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
try:
2020
from google.api_core.gapic_v1.requests import setup_request_id # type: ignore
2121
except ImportError: # pragma: NO COVER
22-
# TODO(https://github.com/googleapis/google-cloud-python/issues/17812): Remove this fallback when google-api-core >= 2.26.0 is the minimum required version.
22+
# TODO(https://github.com/googleapis/google-cloud-python/issues/17813): Remove this fallback when google-api-core >= 2.26.0 is the minimum required version.
2323
def setup_request_id(request, field_name: str, is_proto3_optional: bool):
2424
"""Populate a UUID4 field in the request if it is not already set.
2525

0 commit comments

Comments
 (0)