Skip to content

Commit 227fb76

Browse files
committed
fix mypy failures
1 parent d428370 commit 227fb76

File tree

2 files changed

+24
-13
lines changed

2 files changed

+24
-13
lines changed

packages/bigframes/bigframes/core/global_session.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ def with_default_session(func_: Callable[..., _T], *args, **kwargs) -> _T:
126126
return func_(get_global_session(), *args, **kwargs)
127127

128128

129-
def execution_history() -> "pandas.DataFrame":
129+
def execution_history() -> "bigframes.session._ExecutionHistory":
130130
import pandas # noqa: F401
131131

132132
import bigframes.session

packages/bigframes/bigframes/session/__init__.py

Lines changed: 23 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,7 @@ def format_url(url):
146146

147147
return df_display.to_html(escape=False, index=False)
148148
except Exception:
149-
return self._df._repr_html_()
149+
return self._df.to_html()
150150

151151

152152
@log_adapter.class_logger
@@ -480,7 +480,8 @@ def read_gbq( # type: ignore[overload-overlap]
480480
col_order: Iterable[str] = ...,
481481
dry_run: Literal[False] = ...,
482482
allow_large_results: Optional[bool] = ...,
483-
) -> dataframe.DataFrame: ...
483+
) -> dataframe.DataFrame:
484+
...
484485

485486
@overload
486487
def read_gbq(
@@ -496,7 +497,8 @@ def read_gbq(
496497
col_order: Iterable[str] = ...,
497498
dry_run: Literal[True] = ...,
498499
allow_large_results: Optional[bool] = ...,
499-
) -> pandas.Series: ...
500+
) -> pandas.Series:
501+
...
500502

501503
def read_gbq(
502504
self,
@@ -568,7 +570,8 @@ def _read_gbq_colab(
568570
*,
569571
pyformat_args: Optional[Dict[str, Any]] = None,
570572
dry_run: Literal[False] = ...,
571-
) -> dataframe.DataFrame: ...
573+
) -> dataframe.DataFrame:
574+
...
572575

573576
@overload
574577
def _read_gbq_colab(
@@ -577,7 +580,8 @@ def _read_gbq_colab(
577580
*,
578581
pyformat_args: Optional[Dict[str, Any]] = None,
579582
dry_run: Literal[True] = ...,
580-
) -> pandas.Series: ...
583+
) -> pandas.Series:
584+
...
581585

582586
@log_adapter.log_name_override("read_gbq_colab")
583587
def _read_gbq_colab(
@@ -638,7 +642,8 @@ def read_gbq_query( # type: ignore[overload-overlap]
638642
filters: third_party_pandas_gbq.FiltersType = ...,
639643
dry_run: Literal[False] = ...,
640644
allow_large_results: Optional[bool] = ...,
641-
) -> dataframe.DataFrame: ...
645+
) -> dataframe.DataFrame:
646+
...
642647

643648
@overload
644649
def read_gbq_query(
@@ -654,7 +659,8 @@ def read_gbq_query(
654659
filters: third_party_pandas_gbq.FiltersType = ...,
655660
dry_run: Literal[True] = ...,
656661
allow_large_results: Optional[bool] = ...,
657-
) -> pandas.Series: ...
662+
) -> pandas.Series:
663+
...
658664

659665
def read_gbq_query(
660666
self,
@@ -801,7 +807,8 @@ def read_gbq_table( # type: ignore[overload-overlap]
801807
use_cache: bool = ...,
802808
col_order: Iterable[str] = ...,
803809
dry_run: Literal[False] = ...,
804-
) -> dataframe.DataFrame: ...
810+
) -> dataframe.DataFrame:
811+
...
805812

806813
@overload
807814
def read_gbq_table(
@@ -815,7 +822,8 @@ def read_gbq_table(
815822
use_cache: bool = ...,
816823
col_order: Iterable[str] = ...,
817824
dry_run: Literal[True] = ...,
818-
) -> pandas.Series: ...
825+
) -> pandas.Series:
826+
...
819827

820828
def read_gbq_table(
821829
self,
@@ -966,23 +974,26 @@ def read_pandas(
966974
pandas_dataframe: pandas.Index,
967975
*,
968976
write_engine: constants.WriteEngineType = "default",
969-
) -> bigframes.core.indexes.Index: ...
977+
) -> bigframes.core.indexes.Index:
978+
...
970979

971980
@typing.overload
972981
def read_pandas(
973982
self,
974983
pandas_dataframe: pandas.Series,
975984
*,
976985
write_engine: constants.WriteEngineType = "default",
977-
) -> bigframes.series.Series: ...
986+
) -> bigframes.series.Series:
987+
...
978988

979989
@typing.overload
980990
def read_pandas(
981991
self,
982992
pandas_dataframe: pandas.DataFrame,
983993
*,
984994
write_engine: constants.WriteEngineType = "default",
985-
) -> dataframe.DataFrame: ...
995+
) -> dataframe.DataFrame:
996+
...
986997

987998
def read_pandas(
988999
self,

0 commit comments

Comments
 (0)