Skip to content

Commit 2374b90

Browse files
fixes
1 parent 68ef9a5 commit 2374b90

2 files changed

Lines changed: 7 additions & 7 deletions

File tree

packages/bigframes/bigframes/session/bq_caching_executor.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -296,7 +296,7 @@ def _export_gbq(
296296
sql=sql,
297297
job_config=job_config,
298298
session=array_value.session,
299-
extra_labels=self._labels,
299+
extra_labels=extra_labels,
300300
)
301301

302302
has_special_dtype_col = any(

packages/bigframes/bigframes/session/proxy_executor.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,11 @@
1414

1515
from __future__ import annotations
1616

17+
from typing import Mapping, Optional
1718
import typing
1819
import uuid
1920
import warnings
2021

21-
import bigframes_vendored.ibis.expr.types as ibis_types
2222
import google.cloud.exceptions
2323

2424
import bigframes.core
@@ -89,7 +89,7 @@ def to_sql(
8989
"""
9090
Convert an ArrayValue to a sql query that will yield its value.
9191
"""
92-
return self._main.to_sql(
92+
return self._ibis_executor.to_sql(
9393
array_value,
9494
offset_column=offset_column,
9595
ordered=ordered,
@@ -106,15 +106,15 @@ def execute(
106106
return self._ibis_executor.execute(array_value, execution_spec)
107107
elif compiler_option == "experimental":
108108
return self._sqlglot_executor.execute(
109-
array_value, execution_spec.add_labels((_COMPILER_LABEL_KEY, "sqlglot"))
109+
array_value, execution_spec.add_labels({_COMPILER_LABEL_KEY: "sqlglot"})
110110
)
111111
else: # stable
112112
correlation_id = f"{uuid.uuid1().hex[:12]}"
113113
try:
114114
return self._sqlglot_executor.execute(
115115
array_value,
116116
execution_spec.add_labels(
117-
(_COMPILER_LABEL_KEY, f"sqlglot-{correlation_id}")
117+
{_COMPILER_LABEL_KEY: f"sqlglot-{correlation_id}"}
118118
),
119119
)
120120
except google.cloud.exceptions.BadRequest as e:
@@ -126,7 +126,7 @@ def execute(
126126
return self._ibis_executor.execute(
127127
array_value,
128128
execution_spec.add_labels(
129-
(_COMPILER_LABEL_KEY, f"ibis-{correlation_id}")
129+
{_COMPILER_LABEL_KEY: f"ibis-{correlation_id}"}
130130
),
131131
)
132132

@@ -144,7 +144,7 @@ def cached(
144144
self,
145145
array_value: bigframes.core.ArrayValue,
146146
*,
147-
config: CacheConfig,
147+
config: executor.CacheConfig,
148148
) -> None:
149149
compiler_option = bigframes.options.experiments.sql_compiler
150150
if compiler_option == "legacy":

0 commit comments

Comments
 (0)