Skip to content

Commit 24731d8

Browse files
committed
fixed lint
1 parent ca8ffa6 commit 24731d8

8 files changed

Lines changed: 9 additions & 33 deletions

File tree

packages/google-cloud-bigtable/google/cloud/bigtable/data/_async/client.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,7 @@
6464
_WarmedInstanceKey,
6565
)
6666
from google.cloud.bigtable.data._metrics import (
67+
ActiveOperationMetric,
6768
BigtableClientSideMetricsController,
6869
OperationType,
6970
tracked_retry,

packages/google-cloud-bigtable/google/cloud/bigtable/data/_metrics/handlers/gcp_exporter.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@
5959
3, 4, 5, 6, 8, 10, 13, 16, 20, 25, 30, 40, 50,
6060
65, 80, 100, 130, 160, 200, 250, 300, 400, 500,
6161
650, 800, 900, 1_000, 2_000, 3_000, 4_000,
62-
5_000, 6_000, 10_000, 20_000, 50_000,
62+
5_000, 6_000, 10_000, 20_000, 50_000,
6363
100_000, 200_000, 500_000,
6464
1_000_000, 2_000_000, 5_000_000,
6565
]

packages/google-cloud-bigtable/google/cloud/bigtable/data/_sync_autogen/client.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,7 @@
5858
_WarmedInstanceKey,
5959
)
6060
from google.cloud.bigtable.data._metrics import (
61+
ActiveOperationMetric,
6162
BigtableClientSideMetricsController,
6263
OperationType,
6364
tracked_retry,

packages/google-cloud-bigtable/tests/unit/data/_async/test_client.py

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -237,9 +237,7 @@ async def test_metrics_exporter_init_shares_arguments(
237237
expected_options = client_options.ClientOptions()
238238
expected_options.credentials_file = None
239239
expected_options.quota_project_id = None
240-
mock_called = (
241-
exporter_mock_async if CrossSync.is_async else exporter_mock_sync
242-
)
240+
mock_called = exporter_mock_async if CrossSync.is_async else exporter_mock_sync
243241
async with self._make_client(
244242
project=expected_project,
245243
credentials=expected_credentials,
@@ -255,9 +253,7 @@ async def test_metrics_exporter_init_shares_arguments(
255253
@CrossSync.pytest
256254
async def test_metrics_exporter_init_implicit_project(self):
257255
async with self._make_client(use_emulator=False) as client:
258-
assert (
259-
client._metrics.handlers[0]._exporter.project_id == client.project
260-
)
256+
assert client._metrics.handlers[0]._exporter.project_id == client.project
261257

262258
@CrossSync.pytest
263259
@mock.patch("google.cloud.bigtable.data._async.client.BigtableMetricsExporter")
@@ -1769,9 +1765,7 @@ async def test_create_operation_table_id(self):
17691765
from google.cloud.bigtable.data._metrics.data_model import OperationType
17701766

17711767
client = self._make_client()
1772-
view = self._make_one(
1773-
client, table_id="underlying-table", view_id="my-view"
1774-
)
1768+
view = self._make_one(client, table_id="underlying-table", view_id="my-view")
17751769
op = view._create_operation(OperationType.READ_ROWS)
17761770
assert op.table_id == "underlying-table"
17771771
await client.close()
@@ -2024,9 +2018,6 @@ def _make_table(self, *args, **kwargs):
20242018
from google.cloud.bigtable.data._metrics import (
20252019
BigtableClientSideMetricsController,
20262020
)
2027-
from google.cloud.bigtable.data._metrics.handlers.gcp_exporter import (
2028-
BigtableMetricsExporter,
2029-
)
20302021

20312022
client_mock = mock.Mock()
20322023
client_mock._metrics = BigtableClientSideMetricsController(handlers=[])

packages/google-cloud-bigtable/tests/unit/data/_async/test_mutations_batcher.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1205,9 +1205,6 @@ async def test_customizable_retryable_errors(
12051205
ActiveOperationMetric,
12061206
BigtableClientSideMetricsController,
12071207
)
1208-
from google.cloud.bigtable.data._metrics.handlers.gcp_exporter import (
1209-
BigtableMetricsExporter,
1210-
)
12111208

12121209
mock_client = mock.Mock()
12131210
mock_client._metrics = BigtableClientSideMetricsController(handlers=[])

packages/google-cloud-bigtable/tests/unit/data/_metrics/test_opentelemetry_handler.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,6 @@
1111
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
1212
# See the License for the specific language governing permissions and
1313
# limitations under the License.
14-
import dataclasses
15-
1614
import mock
1715
import pytest
1816
from grpc import StatusCode

packages/google-cloud-bigtable/tests/unit/data/_sync_autogen/test_client.py

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -207,9 +207,7 @@ def test_metrics_exporter_init_shares_arguments(
207207
expected_options.credentials_file = None
208208
expected_options.quota_project_id = None
209209
mock_called = (
210-
exporter_mock_async
211-
if CrossSync._Sync_Impl.is_async
212-
else exporter_mock_sync
210+
exporter_mock_async if CrossSync._Sync_Impl.is_async else exporter_mock_sync
213211
)
214212
with self._make_client(
215213
project=expected_project,
@@ -225,9 +223,7 @@ def test_metrics_exporter_init_shares_arguments(
225223

226224
def test_metrics_exporter_init_implicit_project(self):
227225
with self._make_client(use_emulator=False) as client:
228-
assert (
229-
client._metrics.handlers[0]._exporter.project_id == client.project
230-
)
226+
assert client._metrics.handlers[0]._exporter.project_id == client.project
231227

232228
@mock.patch("google.cloud.bigtable.data._async.client.BigtableMetricsExporter")
233229
@mock.patch(
@@ -1474,9 +1470,7 @@ def test_create_operation_table_id(self):
14741470
from google.cloud.bigtable.data._metrics.data_model import OperationType
14751471

14761472
client = self._make_client()
1477-
view = self._make_one(
1478-
client, table_id="underlying-table", view_id="my-view"
1479-
)
1473+
view = self._make_one(client, table_id="underlying-table", view_id="my-view")
14801474
op = view._create_operation(OperationType.READ_ROWS)
14811475
assert op.table_id == "underlying-table"
14821476
client.close()
@@ -1695,9 +1689,6 @@ def _make_table(self, *args, **kwargs):
16951689
from google.cloud.bigtable.data._metrics import (
16961690
BigtableClientSideMetricsController,
16971691
)
1698-
from google.cloud.bigtable.data._metrics.handlers.gcp_exporter import (
1699-
BigtableMetricsExporter,
1700-
)
17011692

17021693
client_mock = mock.Mock()
17031694
client_mock._metrics = BigtableClientSideMetricsController(handlers=[])

packages/google-cloud-bigtable/tests/unit/data/_sync_autogen/test_mutations_batcher.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1050,9 +1050,6 @@ def test_customizable_retryable_errors(self, input_retryables, expected_retryabl
10501050
ActiveOperationMetric,
10511051
BigtableClientSideMetricsController,
10521052
)
1053-
from google.cloud.bigtable.data._metrics.handlers.gcp_exporter import (
1054-
BigtableMetricsExporter,
1055-
)
10561053

10571054
mock_client = mock.Mock()
10581055
mock_client._metrics = BigtableClientSideMetricsController(handlers=[])

0 commit comments

Comments
 (0)