Skip to content

Commit 2d7e533

Browse files
committed
address PR feedback
1 parent b91c666 commit 2d7e533

File tree

1 file changed

+39
-4
lines changed

1 file changed

+39
-4
lines changed

.github/workflows/gapic-generator-tests.yml

Lines changed: 39 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -44,16 +44,17 @@ jobs:
4444
# Preserve the workaround for env variables in matrix
4545
python_config:
4646
needs: check_changes
47+
if: ${{ needs.check_changes.outputs.run_generator == 'true' }}
4748
runs-on: ubuntu-latest
4849
outputs:
4950
all_python: ${{ env.ALL_PYTHON }}
5051
oldest_python: ${{ env.OLDEST_PYTHON }}
5152
latest_stable_python: ${{ env.LATEST_STABLE_PYTHON }}
5253
steps:
53-
- run: echo "Initializing config"
54+
- run: echo "Initializing config for gapic-generator"
5455

5556
showcase-unit:
56-
needs: [check_changes, python_config]
57+
needs: python_config
5758
strategy:
5859
fail-fast: false
5960
matrix:
@@ -82,8 +83,42 @@ jobs:
8283
cd packages/gapic-generator
8384
nox -s showcase_unit${{ matrix.variant }}-${{ matrix.python }}
8485
86+
showcase-mypy:
87+
needs: python_config
88+
runs-on: ubuntu-latest
89+
steps:
90+
- uses: actions/checkout@v5
91+
- name: Set up Python
92+
uses: actions/setup-python@v6
93+
with:
94+
python-version: ${{ env.LATEST_STABLE_PYTHON }}
95+
- name: Run Mypy
96+
run: |
97+
pip install nox
98+
cd packages/gapic-generator
99+
nox -s showcase_mypy
100+
85101
goldens:
86-
needs: [check_changes, python_config]
102+
needs: python_config
103+
runs-on: ubuntu-latest
104+
steps:
105+
- uses: actions/checkout@v5
106+
- name: Set up Python
107+
uses: actions/setup-python@v6
108+
with:
109+
python-version: ${{ needs.python_config.outputs.latest_stable_python }}
110+
- name: Install System Deps
111+
run: sudo apt-get update && sudo apt-get install -y pandoc
112+
- name: Run Goldens
113+
run: |
114+
pip install nox
115+
cd packages/gapic-generator
116+
for pkg in credentials eventarc logging redis; do
117+
nox -f tests/integration/goldens/$pkg/noxfile.py -s format lint unit-${{ env.LATEST_STABLE_PYTHON }}
118+
done
119+
120+
goldens-prerelease:
121+
needs: python_config
87122
runs-on: ubuntu-latest
88123
steps:
89124
- uses: actions/checkout@v5
@@ -102,7 +137,7 @@ jobs:
102137
done
103138
104139
fragment-snippet:
105-
needs: [check_changes, python_config]
140+
needs: python_config
106141
strategy:
107142
matrix:
108143
python: ["3.10", "3.14"]

0 commit comments

Comments
 (0)