Skip to content

Commit 2e2ab7d

Browse files
committed
feat(firestore): *DocumentReference: add types
1 parent 05ed91d commit 2e2ab7d

File tree

4 files changed

+129
-43
lines changed

4 files changed

+129
-43
lines changed

packages/google-cloud-firestore/google/cloud/firestore_v1/_helpers.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1133,7 +1133,7 @@ def modify_write(self, write, *unused_args, **unused_kwargs) -> None:
11331133

11341134
def make_retry_timeout_kwargs(
11351135
retry: retries.Retry | retries.AsyncRetry | object | None, timeout: float | None
1136-
) -> dict:
1136+
) -> dict[str, Any]:
11371137
"""Helper fo API methods which take optional 'retry' / 'timeout' args."""
11381138
kwargs = {}
11391139

packages/google-cloud-firestore/google/cloud/firestore_v1/async_document.py

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818

1919
import datetime
2020
import logging
21-
from typing import AsyncGenerator, Iterable
21+
from typing import TYPE_CHECKING, AsyncGenerator, Iterable
2222

2323
from google.api_core import gapic_v1
2424
from google.api_core import retry_async as retries
@@ -33,10 +33,16 @@
3333
)
3434
from google.cloud.firestore_v1.types import write
3535

36+
if TYPE_CHECKING: # pragma: NO COVER
37+
from google.cloud.firestore_v1.async_client import AsyncClient
38+
else:
39+
AsyncClient = None
40+
41+
3642
logger = logging.getLogger(__name__)
3743

3844

39-
class AsyncDocumentReference(BaseDocumentReference):
45+
class AsyncDocumentReference(BaseDocumentReference[AsyncClient]):
4046
"""A reference to a document in a Firestore database.
4147
4248
The document may already exist or can be created by this class.

0 commit comments

Comments
 (0)