address PR feedback

Author: ohmayr

.librarian/generator-input/client-post-processing/firestore-integration.yaml

@@ -564,6 +564,9 @@ replacements:
           "freezegun",
       ]
     count: 1
+  # TODO(https://github.com/googleapis/google-cloud-python/issues/17429):
+  # Temporary post-processing rule to add pytest-xdist dependency.
+  # Remove this once gapic-generator includes pytest-xdist by default.
   - paths: [
       packages/google-cloud-firestore/noxfile.py
     ]
@@ -574,6 +577,7 @@ replacements:
           "pytest-asyncio",
           "six",
           "pyyaml",
+          "pytest-xdist",
       ]
     count: 1
   - paths: [
@@ -584,6 +588,54 @@ replacements:
     after: |
       "pytest-asyncio==0.21.2",
     count: 2
+  # TODO(https://github.com/googleapis/google-cloud-python/issues/17429):
+  # Temporary post-processing rule to inject `-n auto` for Firestore parallel tests.
+  # This rule should be removed once the generator template changes are released
+  # and the generator version is updated in librarian.yaml.
+  - paths: [
+      packages/google-cloud-firestore/noxfile.py
+    ]
+    before: |
+      # Run py.test against the system tests\.
+      if system_test_exists:
+          session\.run\(
+              "py.test",
+              "--quiet",
+              f"--junitxml=system_\{session\.python\}_sponge_log\.xml",
+              system_test_path,
+              \*session\.posargs,
+          \)
+      if system_test_folder_exists:
+          session\.run\(
+              "py.test",
+              "--quiet",
+              f"--junitxml=system_\{session\.python\}_sponge_log\.xml",
+              system_test_folder_path,
+              \*session\.posargs,
+          \)
+    after: |
+      # Run py.test against the system tests.
+      if system_test_exists:
+          session.run(
+              "py.test",
+              "-n",
+              "auto",
+              "--quiet",
+              f"--junitxml=system_{session.python}_sponge_log.xml",
+              system_test_path,
+              *session.posargs,
+          )
+      if system_test_folder_exists:
+          session.run(
+              "py.test",
+              "-n",
+              "auto",
+              "--quiet",
+              f"--junitxml=system_{session.python}_sponge_log.xml",
+              system_test_folder_path,
+              *session.posargs,
+          )
+    count: 1
   - paths: [
       "packages/google-cloud-firestore/docs/conf.py",
     ]

packages/google-cloud-firestore/tests/system/test_system.py

@@ -2336,6 +2336,10 @@ def test_watch_document(client, cleanup, database):
     doc_ref.set({"first": "Jane", "last": "Doe", "born": 1900})
     cleanup(doc_ref.delete)
 
+    # TODO(https://github.com/googleapis/google-cloud-python/issues/17428):
+    # Investigate why these sleep/polling delays are needed for listener tests.
+    # Having arbitrary delays is fragile and can lead to flakiness.
+    # Explore event-driven synchronization.
     sleep(0.2)
 
     # Setup listener
@@ -2384,6 +2388,10 @@ def on_snapshot(docs, changes, read_time):
 
     collection_ref.on_snapshot(on_snapshot)
 
+    # TODO(https://github.com/googleapis/google-cloud-python/issues/17428):
+    # Investigate why these sleep/polling delays are needed for listener tests.
+    # Having arbitrary delays is fragile and can lead to flakiness.
+    # Explore event-driven synchronization.
     # delay here so initial on_snapshot occurs and isn't combined with set
     sleep(0.2)
 
@@ -2411,6 +2419,10 @@ def test_watch_query(client, cleanup, database):
     doc_ref.set({"first": "Jane", "last": "Doe", "born": 1900})
     cleanup(doc_ref.delete)
 
+    # TODO(https://github.com/googleapis/google-cloud-python/issues/17428):
+    # Investigate why these sleep/polling delays are needed for listener tests.
+    # Having arbitrary delays is fragile and can lead to flakiness.
+    # Explore event-driven synchronization.
     sleep(0.2)
 
     # Setup listener
@@ -2806,6 +2818,10 @@ def on_snapshot(docs, changes, read_time):
     on_snapshot.failed = None
     query_ref.on_snapshot(on_snapshot)
 
+    # TODO(https://github.com/googleapis/google-cloud-python/issues/17428):
+    # Investigate why these sleep/polling delays are needed for listener tests.
+    # Having arbitrary delays is fragile and can lead to flakiness.
+    # Explore event-driven synchronization.
     sleep(0.2)
 
     doc_ref1.set({"first": "Ada", "last": "Lovelace", "born": 1815})