Skip to content

Commit 331784d

Browse files
committed
Reverting the last 3 commits to allow discussion
1 parent 6281aad commit 331784d

File tree

2 files changed

+4
-12
lines changed

2 files changed

+4
-12
lines changed

packages/bigframes/bigframes/core/compile/sqlglot/sqlglot_ir.py

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -214,14 +214,8 @@ def from_table(
214214
if not columns and not sql_predicate:
215215
return cls.from_expr(expr=table_expr, uid_gen=uid_gen)
216216

217-
# Qualify column references with the table alias to avoid ambiguity
218-
# when a table and a column share the same name. Without this, BigQuery
219-
# might interpret the column as a reference to the table (STRUCT),
220-
# causing failures when casting (e.g. in test_read_gbq_w_ambigous_name).
221-
select_items: list[sge.Expression] = (
222-
[sge.Column(this=sql.identifier(col), table=sql.identifier(table_alias)) for col in columns]
223-
if columns
224-
else [sge.Star()]
217+
select_items: list[sge.Identifier | sge.Star] = (
218+
[sql.identifier(col) for col in columns] if columns else [sge.Star()]
225219
)
226220
select_expr = sge.Select().select(*select_items).from_(table_expr)
227221

packages/bigframes/bigframes/series.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1146,12 +1146,10 @@ def nsmallest(self, n: int = 5, keep: str = "first") -> Series:
11461146
)
11471147

11481148
def isin(self, values) -> "Series":
1149-
# Block.isin can return nulls for non-matching rows, but pandas.isin
1150-
# always returns boolean (False for non-matches). We fill nulls with False.
11511149
if isinstance(values, Series):
1152-
return Series(self._block.isin(values._block)).fillna(value=False)
1150+
return Series(self._block.isin(values._block))
11531151
if isinstance(values, indexes.Index):
1154-
return Series(self._block.isin(values.to_series()._block)).fillna(value=False)
1152+
return Series(self._block.isin(values.to_series()._block))
11551153
if not _is_list_like(values):
11561154
raise TypeError(
11571155
"only list-like objects are allowed to be passed to "

0 commit comments

Comments
 (0)