Skip to content

Commit 3757ee2

Browse files
committed
chore(sqlalchemy-bigquery): restore fail_under=100 in .coveragerc and noxfile
1 parent e41196b commit 3757ee2

3 files changed

Lines changed: 11 additions & 3 deletions

File tree

packages/sqlalchemy-bigquery/.coveragerc

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,15 +14,14 @@
1414
# See the License for the specific language governing permissions and
1515
# limitations under the License.
1616

17-
# Generated by synthtool. DO NOT EDIT!
1817
[run]
1918
branch = True
2019
omit =
2120
google/__init__.py
2221
sqlalchemy_bigquery/requirements.py
2322

2423
[report]
25-
fail_under = 98
24+
fail_under = 100
2625
show_missing = True
2726
exclude_lines =
2827
# Re-enable the standard pragma
@@ -37,3 +36,5 @@ omit =
3736
*/core/*.py
3837
*/site-packages/*.py
3938
sqlalchemy_bigquery/requirements.py
39+
tests/*
40+
*/tests/*

packages/sqlalchemy-bigquery/noxfile.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -467,7 +467,7 @@ def cover(session):
467467
test runs (not system test runs), and then erases coverage data.
468468
"""
469469
session.install("coverage", "pytest-cov")
470-
session.run("coverage", "report", "--show-missing")
470+
session.run("coverage", "report", "--show-missing", "--fail-under=100")
471471

472472
session.run("coverage", "erase")
473473

packages/sqlalchemy-bigquery/tests/unit/test_engine.py

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,3 +70,10 @@ def test_arraysize_querystring_takes_precedence_over_default(faux_conn, metadata
7070
metadata.create_all(engine)
7171

7272
assert conn.connection.test_data["arraysize"] == arraysize
73+
74+
75+
def test_dbapi_deprecated():
76+
from sqlalchemy_bigquery.base import BigQueryDialect
77+
78+
assert BigQueryDialect.dbapi() is BigQueryDialect.import_dbapi()
79+

0 commit comments

Comments
 (0)