Skip to content

Commit 392fad7

Browse files
committed
fix(version-scanner): tighten regex rules based on PR feedback
1 parent 24d1da4 commit 392fad7

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

scripts/version_scanner/regex_pattern_config.yaml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,7 @@ rules:
163163
- 'PROTOBUF_VERSION[0:2] in ("3.", "4.")'
164164
rules:
165165
- |
166-
{name}_VERSION(?:\[.*?\])?\s+in\s+[\(\[\{{].*?['"]?{major}\b.*?[\)\]\}}]
166+
{name}_VERSION(?:\[.*?\])?\s+in\s+[\(\[\{{].*?['"]?(?<!\.)\b{major}\b.*?[\)\]\}}]
167167
168168
- name: dependency_wildcard_assignment
169169
description: Finds wildcard version specifications in code assignments or requirements.
@@ -181,7 +181,7 @@ rules:
181181
- "protobuf 3.*"
182182
rules:
183183
- |
184-
{name}\s+.*{major}\.[x\*](?!\w)
184+
{name}\s+(?:version\s+)?{major}\.[x\*](?!\w)
185185
186186
- name: dependency_flexible_version
187187
description: Finds versions with varying levels of specificity with accompanying qualifier.
@@ -215,7 +215,7 @@ rules:
215215
- "protobuf.__version__"
216216
- "importlib.metadata.version('protobuf')"
217217
- "pkg_resources.get_distribution('protobuf')"
218-
- "packaging.version"
218+
- "packaging.version # protobuf"
219219
- "dist.metadata['Name'] == 'protobuf'"
220220
rules:
221221
- |
@@ -225,7 +225,7 @@ rules:
225225
- |
226226
pkg_resources\.get_distribution\s*\(\s*['"]{name}['"]\s*\)
227227
- |
228-
packaging\.version
228+
packaging\.version(?=.*{name})
229229
- |
230230
dist\.metadata\s*\[\s*['"]Name['"]\s*\]\s*==\s*['"]{name}['"]
231231

0 commit comments

Comments
 (0)