Skip to content

Commit 3ab0144

Browse files
committed
address feedback
1 parent 2bd421a commit 3ab0144

2 files changed

Lines changed: 6 additions & 4 deletions

File tree

packages/google-cloud-bigtable/tests/system/data/test_system_async.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -113,8 +113,9 @@ async def delete_rows(self):
113113
# serialization overhead. Keeping chunks at 5,000 ensures we stay safely
114114
# under 4MB and minimizes transient network timeouts on live connections.
115115
chunk_size = 5000
116-
for i in range(0, len(self.rows), chunk_size):
117-
chunk = self.rows[i : i + chunk_size]
116+
rows_list = list(self.rows)
117+
for i in range(0, len(rows_list), chunk_size):
118+
chunk = rows_list[i : i + chunk_size]
118119
request = {
119120
**self.target._request_path,
120121
"entries": [

packages/google-cloud-bigtable/tests/system/data/test_system_autogen.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -95,8 +95,9 @@ def add_aggregate_row(
9595
def delete_rows(self):
9696
if self.rows:
9797
chunk_size = 5000
98-
for i in range(0, len(self.rows), chunk_size):
99-
chunk = self.rows[i : i + chunk_size]
98+
rows_list = list(self.rows)
99+
for i in range(0, len(rows_list), chunk_size):
100+
chunk = rows_list[i : i + chunk_size]
100101
request = {
101102
**self.target._request_path,
102103
"entries": [

0 commit comments

Comments
 (0)