Skip to content

Commit 3f2120d

Browse files
committed
address feedback
1 parent 3ab0144 commit 3f2120d

2 files changed

Lines changed: 10 additions & 2 deletions

File tree

packages/google-cloud-bigtable/tests/system/data/test_system_async.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,11 @@ async def delete_rows(self):
126126
# Await and consume the gRPC stream to guarantee execution
127127
stream = await self.target.client._gapic_client.mutate_rows(request)
128128
async for response in stream:
129-
pass
129+
for entry in response.entries:
130+
if entry.status.code != 0:
131+
raise RuntimeError(
132+
f"Failed to delete row: {entry.status.message}"
133+
)
130134

131135
@CrossSync.convert
132136
async def retrieve_cell_value(self, target, row_key):

packages/google-cloud-bigtable/tests/system/data/test_system_autogen.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,11 @@ def delete_rows(self):
107107
}
108108
stream = self.target.client._gapic_client.mutate_rows(request)
109109
for response in stream:
110-
pass
110+
for entry in response.entries:
111+
if entry.status.code != 0:
112+
raise RuntimeError(
113+
f"Failed to delete row: {entry.status.message}"
114+
)
111115

112116
def retrieve_cell_value(self, target, row_key):
113117
"""Helper to read an individual row"""

0 commit comments

Comments
 (0)