added auto-cleanup

Author: daniel-sanche

packages/google-cloud-bigquery/tests/system/test_ssl_retry.py

@@ -29,40 +29,40 @@ def test_insert_rows_json_ssl_error_no_retry(bigquery_client, dataset_id, projec
     schema = [bigquery.SchemaField("name", "STRING")]
     table = bigquery.Table(table_id, schema=schema)
     bigquery_client.create_table(table)
-    
-    # We mock the api_request to simulate the GFE abruptly closing the connection
-    # which manifests as a requests.exceptions.SSLError.
-    original_api_request = bigquery_client._connection.api_request
-    call_count = 0
+    try:
+        # We mock the api_request to simulate the GFE abruptly closing the connection
+        # which manifests as a requests.exceptions.SSLError.
+        original_api_request = bigquery_client._connection.api_request
+        call_count = 0
 
-    def mock_api_request(*args, **kwargs):
-        nonlocal call_count
-        call_count += 1
-        raise requests.exceptions.SSLError("EOF occurred in violation of protocol")
+        def mock_api_request(*args, **kwargs):
+            nonlocal call_count
+            call_count += 1
+            raise requests.exceptions.SSLError("EOF occurred in violation of protocol")
 
-    with mock.patch.object(bigquery_client._connection, "api_request", side_effect=mock_api_request):
-        # Use a reasonably short deadline for the test, although it should fail on the first attempt anyway.
-        retry = bigquery.DEFAULT_RETRY.with_deadline(5.0)
-        
-        start_time = time.time()
-        with pytest.raises(requests.exceptions.SSLError) as excinfo:
-            bigquery_client.insert_rows_json(
-                table, 
-                [{"name": "test"}],
-                retry=retry
-            )
-        duration = time.time() - start_time
+        with mock.patch.object(bigquery_client._connection, "api_request", side_effect=mock_api_request):
+            # Use a reasonably short deadline for the test, although it should fail on the first attempt anyway.
+            retry = bigquery.DEFAULT_RETRY.with_deadline(5.0)
 
-    # Verification:
-    # 1. It should NOT have retried (total calls should be 1)
-    assert call_count == 1
-    
-    # 2. It should have failed quickly (much less than the 5s deadline)
-    assert duration < 2.0
-    
-    # 3. The error message should contain our descriptive wrapping
-    assert "invalid table schema" in str(excinfo.value)
-    assert "SSL/Connection error occurred" in str(excinfo.value)
+            start_time = time.time()
+            with pytest.raises(requests.exceptions.SSLError) as excinfo:
+                bigquery_client.insert_rows_json(
+                    table, 
+                    [{"name": "test"}],
+                    retry=retry
+                )
+            duration = time.time() - start_time
 
-    # Cleanup
-    bigquery_client.delete_table(table_id)
+        # Verification:
+        # 1. It should NOT have retried (total calls should be 1)
+        assert call_count == 1
+
+        # 2. It should have failed quickly (much less than the 5s deadline)
+        assert duration < 2.0
+
+        # 3. The error message should contain our descriptive wrapping
+        assert "invalid table schema" in str(excinfo.value)
+        assert "SSL/Connection error occurred" in str(excinfo.value)
+    finally:
+        # Cleanup
+        bigquery_client.delete_table(table_id)