Skip to content

Commit 4659080

Browse files
committed
fix(generator): update fallback proto-plus check to exactly match api_core requests.py
1 parent a8105ff commit 4659080

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

  • packages/gapic-generator
    • gapic/templates/%namespace/%name_%version/%sub
    • tests/integration/goldens/storagebatchoperations/google/cloud/storagebatchoperations_v1

packages/gapic-generator/gapic/templates/%namespace/%name_%version/%sub/_compat.py.j2

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ except ImportError: # pragma: NO COVER
3030
setattr(request, field_name, request_id_val)
3131
except (AttributeError, ValueError):
3232
# Proto-plus messages or other objects
33-
if not getattr(request, field_name, None):
33+
if getattr(request, field_name, None) is None:
3434
setattr(request, field_name, request_id_val)
3535
else:
3636
if not getattr(request, field_name, None):

packages/gapic-generator/tests/integration/goldens/storagebatchoperations/google/cloud/storagebatchoperations_v1/_compat.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,8 @@ def setup_request_id(request, field_name: str, is_proto3_optional: bool): # pra
4343
setattr(request, field_name, request_id_val)
4444
except (AttributeError, ValueError):
4545
# Proto-plus messages or other objects
46-
if not getattr(request, field_name, None):
46+
if getattr(request, field_name, None) is None:
4747
setattr(request, field_name, request_id_val)
4848
else:
49-
if not getattr(request, field_name, None):
49+
if getattr(request, field_name, None) is None:
5050
setattr(request, field_name, request_id_val)

0 commit comments

Comments
 (0)