Skip to content

Commit 48f9953

Browse files
committed
chore: adjusts type hints to account for complications with mypy part 5
1 parent c714005 commit 48f9953

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

packages/bigframes/bigframes/core/local_data.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,7 @@ def to_arrow(
156156
return schema, batches
157157

158158
def is_nullable(self, column_id: identifiers.ColumnId) -> bool:
159-
return self.data.column(column_id).null_count > 0
159+
return self.data.column(column_id.name).null_count > 0
160160

161161
def to_pyarrow_table(
162162
self,

packages/bigframes/tests/unit/test_local_engine.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -171,8 +171,11 @@ def test_polars_local_engine_agg(polars_session):
171171
pd_result = pd_df.agg(["sum", "count"])
172172
# local engine appears to produce uint32
173173
pandas.testing.assert_frame_equal(
174-
bf_result, pd_result, check_dtype=False, check_index_type=False
175-
) # type: ignore
174+
bf_result, # type: ignore[arg-type]
175+
pd_result,
176+
check_dtype=False,
177+
check_index_type=False,
178+
)
176179

177180

178181
def test_polars_local_engine_groupby_sum(polars_session):

0 commit comments

Comments
 (0)