Skip to content

Commit 49db5a1

Browse files
committed
address feedback
1 parent fec974b commit 49db5a1

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

packages/gapic-generator/rules_python_gapic/py_gapic.bzl

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -76,18 +76,18 @@ def py_gapic_library(
7676
deps = [],
7777
**kwargs):
7878

79-
# Dynamically wrap input proto targets with the gapic_compat_proto_library adapter
80-
# to convert modern Starlark ProtoInfo into rules_gapic's expected CustomProtoInfo.
81-
# We extract and propagate 'testonly' from kwargs to prevent Bazel dependency analysis
82-
# errors when py_gapic_library or its input proto targets are marked testonly = True.
79+
# We extract and propagate 'testonly' and 'tags' from kwargs to prevent Bazel dependency analysis
80+
# errors and ensure wildcard builds (e.g. manual tags) behave correctly.
8381
testonly = kwargs.get("testonly", False)
82+
tags = kwargs.get("tags", [])
8483
compat_srcs = []
8584
for i, src in enumerate(srcs):
8685
compat_name = "%s_compat_src_%d" % (name, i)
8786
gapic_compat_proto_library(
8887
name = compat_name,
8988
dep = src,
9089
testonly = testonly,
90+
tags = tags,
9191
)
9292
compat_srcs.append(":%s" % compat_name)
9393

0 commit comments

Comments
 (0)