pr comments

Author: TrevorBergeron

packages/bigframes/bigframes/session/bq_caching_executor.py

@@ -81,7 +81,7 @@ def __init__(
         enable_polars_execution: bool = False,
         publisher: bigframes.core.events.Publisher,
         labels: tuple[tuple[str, str], ...] = (),
-        compiler_name: Literal["ibis", "sqlglot"] = "ibis",
+        compiler_name: Literal["ibis", "sqlglot"] = "sqlglot",
         cache: Optional[execution_cache.ExecutionCache] = None,
     ):
         self.bqclient = bqclient
@@ -376,8 +376,9 @@ def _run_execute_query(
                 bigframes.options.compute.maximum_bytes_billed
             )
 
-        if self._labels or extra_labels:
+        if self._labels:
             job_config.labels.update(self._labels)
+        if extra_labels:
             job_config.labels.update(extra_labels)
 
         try:

packages/bigframes/bigframes/session/proxy_executor.py

@@ -91,6 +91,17 @@ def to_sql(
         """
         Convert an ArrayValue to a sql query that will yield its value.
         """
+        compiler_option = bigframes.options.experiments.sql_compiler
+        # Use ibis unless sqlglot explicitly selected, since we can't handle errors resulting
+        # from use of the sql produced by this method.
+        if compiler_option == "experimental":
+            return self._sqlglot_executor.to_sql(
+                array_value,
+                offset_column=offset_column,
+                ordered=ordered,
+                enable_cache=enable_cache,
+            )
+        # stable or legacy use ibis
         return self._ibis_executor.to_sql(
             array_value,
             offset_column=offset_column,