Skip to content

Commit 577b6b0

Browse files
committed
chore: updates imports to avoid circular import errors
1 parent 312bc32 commit 577b6b0

File tree

12 files changed

+35
-33
lines changed

12 files changed

+35
-33
lines changed

packages/google-cloud-spanner/google/cloud/spanner_v1/_opentelemetry_tracing.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,8 @@
2525
)
2626
from opentelemetry.trace.status import Status, StatusCode
2727

28-
from google.cloud.spanner_v1 import SpannerClient, gapic_version
28+
from google.cloud.spanner_v1.services.spanner import SpannerClient
29+
from google.cloud.spanner_v1 import gapic_version
2930
from google.cloud.spanner_v1._helpers import (
3031
_get_cloud_region,
3132
_metadata_with_span_context,

packages/google-cloud-spanner/google/cloud/spanner_v1/batch.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,14 +20,14 @@
2020

2121
from google.api_core.exceptions import InternalServerError
2222

23-
from google.cloud.spanner_v1 import (
23+
from google.cloud.spanner_v1.types.spanner import (
2424
BatchWriteRequest,
2525
CommitRequest,
26-
CommitResponse,
27-
Mutation,
2826
RequestOptions,
29-
TransactionOptions,
3027
)
28+
from google.cloud.spanner_v1.types.commit_response import CommitResponse
29+
from google.cloud.spanner_v1.types.mutation import Mutation
30+
from google.cloud.spanner_v1.types.transaction import TransactionOptions
3131
from google.cloud.spanner_v1._helpers import (
3232
AtomicCounter,
3333
_check_rst_stream_error,

packages/google-cloud-spanner/google/cloud/spanner_v1/client.py

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -48,11 +48,9 @@
4848
from google.cloud.spanner_admin_instance_v1.services.instance_admin.transports.grpc import (
4949
InstanceAdminGrpcTransport,
5050
)
51-
from google.cloud.spanner_v1 import (
52-
DefaultTransactionOptions,
53-
ExecuteSqlRequest,
54-
__version__,
55-
)
51+
from google.cloud.spanner_v1.transaction import DefaultTransactionOptions
52+
from google.cloud.spanner_v1.types.spanner import ExecuteSqlRequest
53+
from google.cloud.spanner_v1.gapic_version import __version__
5654
from google.cloud.spanner_v1._helpers import (
5755
_create_experimental_host_transport,
5856
_merge_query_options,

packages/google-cloud-spanner/google/cloud/spanner_v1/database.py

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -40,16 +40,14 @@
4040
)
4141
from google.cloud.spanner_admin_database_v1 import Database as DatabasePB
4242
from google.cloud.spanner_admin_database_v1.types import DatabaseDialect
43-
from google.cloud.spanner_v1 import (
44-
DefaultTransactionOptions,
45-
ExecuteSqlRequest,
46-
RequestOptions,
47-
SpannerClient,
43+
from google.cloud.spanner_v1.types.spanner import ExecuteSqlRequest, RequestOptions
44+
from google.cloud.spanner_v1.types.transaction import (
4845
TransactionOptions,
4946
TransactionSelector,
50-
Type,
51-
TypeCode,
5247
)
48+
from google.cloud.spanner_v1.types.type import Type, TypeCode
49+
from google.cloud.spanner_v1.transaction import DefaultTransactionOptions
50+
from google.cloud.spanner_v1.services.spanner import SpannerClient
5351
from google.cloud.spanner_v1._helpers import (
5452
_augment_errors_with_request_id,
5553
_create_experimental_host_transport,

packages/google-cloud-spanner/google/cloud/spanner_v1/instance.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@
3535
from google.cloud.spanner_v1._helpers import _metadata_with_prefix
3636
from google.cloud.spanner_v1.backup import Backup
3737
from google.cloud.spanner_v1.database import Database
38-
from google.cloud.spanner_v1.testing.database_test import TestDatabase
3938

4039
_INSTANCE_NAME_RE = re.compile(
4140
r"^projects/(?P<project>[^/]+)/" r"instances/(?P<instance_id>[a-z][-a-z0-9]*)$"
@@ -502,6 +501,8 @@ def database(
502501
proto_descriptors=proto_descriptors,
503502
)
504503
else:
504+
from google.cloud.spanner_v1.testing.database_test import TestDatabase
505+
505506
return TestDatabase(
506507
database_id,
507508
self,

packages/google-cloud-spanner/google/cloud/spanner_v1/keyset.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414

1515
"""Wrap representation of Spanner keys / ranges."""
1616

17-
from google.cloud.spanner_v1 import KeyRangePB, KeySetPB
17+
from google.cloud.spanner_v1.types.keys import KeyRange as KeyRangePB, KeySet as KeySetPB
1818
from google.cloud.spanner_v1._helpers import _make_list_value_pb, _make_list_value_pbs
1919

2020

packages/google-cloud-spanner/google/cloud/spanner_v1/param_types.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
from google.protobuf.internal.enum_type_wrapper import EnumTypeWrapper
1818
from google.protobuf.message import Message
1919

20-
from google.cloud.spanner_v1 import StructType, Type, TypeAnnotationCode, TypeCode
20+
from google.cloud.spanner_v1.types.type import StructType, Type, TypeAnnotationCode, TypeCode
2121

2222
# Scalar parameter types
2323
STRING = Type(code=TypeCode.STRING)

packages/google-cloud-spanner/google/cloud/spanner_v1/pool.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,10 @@
2121

2222
from google.cloud.exceptions import NotFound
2323

24-
from google.cloud.spanner_v1 import BatchCreateSessionsRequest
25-
from google.cloud.spanner_v1 import Session as SessionProto
24+
from google.cloud.spanner_v1.types.spanner import (
25+
BatchCreateSessionsRequest,
26+
Session as SessionProto,
27+
)
2628
from google.cloud.spanner_v1._helpers import (
2729
_metadata_with_leader_aware_routing,
2830
_metadata_with_prefix,

packages/google-cloud-spanner/google/cloud/spanner_v1/session.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
from google.api_core.exceptions import Aborted, GoogleAPICallError, NotFound
2323
from google.api_core.gapic_v1 import method
2424

25-
from google.cloud.spanner_v1 import CreateSessionRequest, ExecuteSqlRequest
25+
from google.cloud.spanner_v1.types.spanner import CreateSessionRequest, ExecuteSqlRequest
2626
from google.cloud.spanner_v1._helpers import (
2727
_delay_until_retry,
2828
_get_retry_delay,

packages/google-cloud-spanner/google/cloud/spanner_v1/snapshot.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,17 +27,18 @@
2727
)
2828
from google.protobuf.struct_pb2 import Struct
2929

30-
from google.cloud.spanner_v1 import (
30+
from google.cloud.spanner_v1.types.spanner import (
3131
BeginTransactionRequest,
3232
ExecuteSqlRequest,
33-
Mutation,
34-
PartialResultSet,
3533
PartitionOptions,
3634
PartitionQueryRequest,
3735
PartitionReadRequest,
3836
ReadRequest,
3937
RequestOptions,
40-
ResultSet,
38+
)
39+
from google.cloud.spanner_v1.types.mutation import Mutation
40+
from google.cloud.spanner_v1.types.result_set import PartialResultSet, ResultSet
41+
from google.cloud.spanner_v1.types.transaction import (
4142
Transaction,
4243
TransactionOptions,
4344
TransactionSelector,

0 commit comments

Comments
 (0)