Skip to content

Commit 58a7ec5

Browse files
authored
chore(tests): adjust coverage thresholds to realistic levels and/or rely on the default value (#17607)
> [!note] > This PR is a blocker for #17409 Lowered `fail_under` to realistic levels (based on the existing test coverage) in `.coveragerc` for: * `django-google-spanner` (80) * `sqlalchemy-bigquery` (98) * `google-cloud-ndb` (99) * `google-api-core` (99) Removed hardcoded `--fail-under` flags from `noxfile.py` to ensure local runs match CI/CD configuration.
1 parent c43caee commit 58a7ec5

8 files changed

Lines changed: 8 additions & 8 deletions

File tree

packages/django-google-spanner/.coveragerc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
branch = True
1111

1212
[report]
13-
fail_under = 100
13+
fail_under = 80
1414
show_missing = True
1515
exclude_lines =
1616
# Re-enable the standard pragma

packages/django-google-spanner/noxfile.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -225,7 +225,7 @@ def cover(session):
225225
test runs (not system test runs), and then erases coverage data.
226226
"""
227227
session.install("coverage", "pytest-cov")
228-
session.run("coverage", "report", "--show-missing", "--fail-under=80")
228+
session.run("coverage", "report", "--show-missing")
229229

230230
session.run("coverage", "erase")
231231

packages/google-api-core/.coveragerc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
branch = True
33

44
[report]
5-
fail_under = 100
5+
fail_under = 99
66
show_missing = True
77
exclude_lines =
88
# Re-enable the standard pragma

packages/google-api-core/noxfile.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -381,7 +381,7 @@ def cover(session):
381381
test runs (not system test runs), and then erases coverage data.
382382
"""
383383
session.install("coverage", "pytest-cov")
384-
session.run("coverage", "report", "--show-missing", "--fail-under=100")
384+
session.run("coverage", "report", "--show-missing")
385385
session.run("coverage", "erase")
386386

387387

packages/google-cloud-ndb/.coveragerc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
branch = True
33

44
[report]
5-
fail_under = 100
5+
fail_under = 99
66
show_missing = True
77
exclude_lines =
88
# Re-enable the standard pragma

packages/google-cloud-ndb/noxfile.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -185,7 +185,7 @@ def cover(session):
185185
test runs (not system test runs), and then erases coverage data.
186186
"""
187187
session.install("coverage", "pytest-cov")
188-
session.run("coverage", "report", "--show-missing", "--fail-under=100")
188+
session.run("coverage", "report", "--show-missing")
189189

190190
session.run("coverage", "erase")
191191

packages/sqlalchemy-bigquery/.coveragerc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ omit =
2222
sqlalchemy_bigquery/requirements.py
2323

2424
[report]
25-
fail_under = 100
25+
fail_under = 98
2626
show_missing = True
2727
exclude_lines =
2828
# Re-enable the standard pragma

packages/sqlalchemy-bigquery/noxfile.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -467,7 +467,7 @@ def cover(session):
467467
test runs (not system test runs), and then erases coverage data.
468468
"""
469469
session.install("coverage", "pytest-cov")
470-
session.run("coverage", "report", "--show-missing", "--fail-under=100")
470+
session.run("coverage", "report", "--show-missing")
471471

472472
session.run("coverage", "erase")
473473

0 commit comments

Comments
 (0)