fix: PR comments and CI failures

* Added clarifying comment on the chunk_size logic.
* Fixed an issue when logger would crash while attempting to read the text of a mocked response that has an empty body

Author: Test User

packages/google-api-core/google/api_core/resumable_media/_upload.py

@@ -72,7 +72,13 @@ def invalid(self) -> bool:
 
     @property
     def chunk_size(self) -> int:
-        """int: The block-aligned chunk size informed by server granularity."""
+        """int: The block-aligned chunk size informed by server granularity.
+
+        All chunks (except the last one) must have a size that is a multiple
+        of the server's chunk granularity. We round the user's requested size
+        up to the nearest granularity multiple to ensure all intermediate
+        chunks conform to this protocol constraint.
+        """
         if self._chunk_granularity:
             return (
                 (self._chunk_size + self._chunk_granularity - 1)

packages/google-api-core/google/api_core/resumable_media/requests_upload.py

@@ -186,12 +186,16 @@ def _log_request(
     def _log_response(self, response: requests.Response):
         if not _LOGGER.isEnabledFor(logging.DEBUG):
             return
+        try:
+            body = response.text
+        except (ValueError, AttributeError):
+            body = "<unavailable or closed>"
         _LOGGER.debug(
             "HTTP Response: %s %s\nHeaders: %s\nBody: %s",
             response.status_code,
             response.reason,
             response.headers,
-            response.text,
+            body,
         )
 
     def initiate(

packages/google-api-core/tests/unit/resumable_media/test_requests_upload.py

@@ -43,7 +43,13 @@ def test_deadline_exceeded():
 
 
 @responses.activate
-def test_happy_path_upload():
+def test_happy_path_upload(caplog):
+    import logging
+
+    caplog.set_level(
+        logging.DEBUG, logger="google.api_core.resumable_media.requests_upload"
+    )
+
     initial_url = "http://example.com/start"
     session_url = "http://example.com/session/123"
     data = b"hello world"
@@ -70,7 +76,7 @@ def test_happy_path_upload():
     session = requests.Session()
     response = requests_upload.make_resumable_upload(
         transport=session,
-        request_body="",
+        request_body="test-initiate-metadata",
         stream=stream,
         upload_url=initial_url,
         size=len(data),
@@ -90,6 +96,13 @@ def test_happy_path_upload():
         == "upload, finalize"
     )
 
+    # Check that the initiation and chunk response logs are successfully written without raising exceptions
+    assert f"HTTP Request: POST {initial_url}" in caplog.text
+    assert "Body: test-initiate-metadata" in caplog.text
+    assert f"HTTP Request: POST {session_url}" in caplog.text
+    assert "HTTP Response: 200" in caplog.text
+    assert "Body: Success" in caplog.text
+
 
 @responses.activate
 def test_upload_with_retry():