Skip to content

Commit 5c7e6e2

Browse files
committed
fix(api-core): call _convert_protobuf_message_to_dict on OperationsTransport instance and add --fail-under=100 to cover session in noxfile
1 parent 3c7735e commit 5c7e6e2

2 files changed

Lines changed: 4 additions & 3 deletions

File tree

packages/google-api-core/noxfile.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -389,7 +389,7 @@ def cover(session):
389389
test runs (not system test runs), and then erases coverage data.
390390
"""
391391
session.install("coverage", "pytest-cov")
392-
session.run("coverage", "report", "--show-missing")
392+
session.run("coverage", "report", "--show-missing", "--fail-under=100")
393393
session.run("coverage", "erase")
394394

395395

packages/google-api-core/tests/unit/operations_v1/test_operations_client.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -108,13 +108,14 @@ def test_operations_v1_transport_base_to_dict_protobuf_versions(monkeypatch):
108108
from google.api_core.operations_v1.transports import base
109109

110110
message = operations_pb2.Operation(name="test_op")
111+
transport = base.OperationsTransport()
111112

112113
monkeypatch.setattr(base, "PROTOBUF_VERSION", "3.20.0")
113-
res3 = base.OperationsTransport._to_dict(message)
114+
res3 = transport._convert_protobuf_message_to_dict(message)
114115
assert res3.get("name") == "test_op"
115116

116117
monkeypatch.setattr(base, "PROTOBUF_VERSION", "5.26.0")
117-
res5 = base.OperationsTransport._to_dict(message)
118+
res5 = transport._convert_protobuf_message_to_dict(message)
118119
assert res5.get("name") == "test_op"
119120

120121

0 commit comments

Comments
 (0)