Skip to content

Commit 6023562

Browse files
fix(firestore): BulkWriter pop from an empty deque
Fixes #16138
1 parent 734302a commit 6023562

1 file changed

Lines changed: 3 additions & 2 deletions

File tree

  • packages/google-cloud-firestore/google/cloud/firestore_v1

packages/google-cloud-firestore/google/cloud/firestore_v1/bulk_writer.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -508,8 +508,9 @@ def _schedule_ready_retries(self) -> None:
508508
)
509509

510510
for _ in range(take_until_index):
511-
retry: OperationRetry = self._retries.popleft()
512-
retry.retry(self)
511+
if self._retries:
512+
retry: OperationRetry = self._retries.popleft()
513+
retry.retry(self)
513514
return None
514515

515516
def _request_send(self, batch_size: int) -> bool:

0 commit comments

Comments
 (0)