link bugs

Author: ohmayr

packages/gapic-generator/noxfile.py

@@ -476,7 +476,8 @@ def showcase_mtls(
         )
 
 
-# TODO(Phase 3): Remove showcase_pqc once grpcio >= 1.83.0 is enforced by default in google-api-core.
+# TODO(https://github.com/googleapis/google-cloud-python/issues/17752):
+# Remove showcase_pqc once grpcio >= 1.83.0 is enforced by default.
 @nox.session(python=NEWEST_PYTHON)
 def showcase_pqc(
     session,
@@ -487,6 +488,8 @@ def showcase_pqc(
     """Run the Showcase PQC verification test suite against grpcio 1.83+ over standard TLS."""
     with showcase_library(session, templates=templates, other_opts=other_opts):
         session.install("pytest", "pytest-asyncio")
+        # TODO(https://github.com/googleapis/google-cloud-python/issues/17751):
+        # Update the version below to `1.83.0` once released, and remove `--pre`.
         session.install("--pre", "--upgrade", "grpcio>=1.83.0rc0", "grpcio-status>=1.83.0rc0")
         session.run("py.test", "--quiet", "--tls", *(session.posargs or ["tests/system/test_pqc.py"]), env=env)
 

packages/gapic-generator/tests/system/test_pqc.py

@@ -42,8 +42,11 @@ def _verify_pqc_metadata(interceptor, transport_name):
 
 def test_pqc_grpc(run_pqc_test, intercepted_echo_grpc):
     """Verifies that the gRPC client library negotiates PQC (X25519MLKEM768) with Showcase server."""
-    # TODO(Phase 3): Remove this check once grpcio >= 1.83.0 is enforced across all client libraries.
+    # TODO(https://github.com/googleapis/google-cloud-python/issues/17752):
+    # Remove this check once grpcio >= 1.83.0 is enforced across all client libraries.
     if Version(grpc.__version__) < Version("1.83.0rc0"):
+        # TODO(https://github.com/googleapis/google-cloud-python/issues/17751): 
+        # Update the version in the check above to `1.83.0` once released.
         pytest.skip(f"gRPC PQC negotiation requires grpcio >= 1.83.0 (current: {grpc.__version__})")
 
     client, interceptor = intercepted_echo_grpc
@@ -63,8 +66,11 @@ def test_pqc_rest(run_pqc_test, intercepted_echo_rest):
 @pytest.mark.asyncio
 async def test_pqc_grpc_async(run_pqc_test, intercepted_echo_grpc_async):
     """Verifies that the async gRPC client library negotiates PQC (X25519MLKEM768) with Showcase server."""
-    # TODO(Phase 3): Remove this check once grpcio >= 1.83.0 is enforced across all client libraries.
+    # TODO(https://github.com/googleapis/google-cloud-python/issues/17752):
+    # Remove this check once grpcio >= 1.83.0 is enforced across all client libraries.
     if Version(grpc.__version__) < Version("1.83.0rc0"):
+        # TODO(https://github.com/googleapis/google-cloud-python/issues/17751): 
+        # Update the version in the check above to `1.83.0` once released.
         pytest.skip(f"gRPC PQC negotiation requires grpcio >= 1.83.0 (current: {grpc.__version__})")
 
     client, interceptor = intercepted_echo_grpc_async