Skip to content

Commit 671d447

Browse files
committed
chore(generator): enable system tests
1 parent 8ed6b71 commit 671d447

1 file changed

Lines changed: 7 additions & 5 deletions

File tree

packages/gapic-generator/noxfile.py

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,7 @@
5454
)
5555

5656
NEWEST_PYTHON = ALL_PYTHON[-2]
57+
SYSTEM_TEST_PYTHON_VERSIONS = ALL_PYTHON
5758

5859

5960
@nox.session(python=ALL_PYTHON)
@@ -816,12 +817,13 @@ def format(session):
816817
)
817818

818819

819-
@nox.session(python=ALL_PYTHON)
820+
@nox.session(python=SYSTEM_TEST_PYTHON_VERSIONS)
820821
def system(session):
821-
# TODO(https://github.com/googleapis/google-cloud-python/issues/16190):
822-
# Implement system test session.
823-
"""Run the system test suite (skipped for migration)."""
824-
session.skip(f"system session is not yet implemented for gapic-generator-python.")
822+
"""Run the system test suite against Showcase."""
823+
# Check the value of `RUN_SYSTEM_TESTS` env var. It defaults to true.
824+
if os.environ.get("RUN_SYSTEM_TESTS", "true") == "false":
825+
session.skip("RUN_SYSTEM_TESTS is set to false, skipping")
826+
showcase(session)
825827

826828

827829
@nox.session(python=NEWEST_PYTHON)

0 commit comments

Comments
 (0)