Skip to content

Commit 70ff308

Browse files
committed
fix(sqlalchemy-bigquery): wrap string in WKT in test_geoalchemy2_orm
1 parent f05c58e commit 70ff308

2 files changed

Lines changed: 1 addition & 9 deletions

File tree

packages/sqlalchemy-bigquery/sqlalchemy_bigquery/geography.py

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -182,19 +182,11 @@ def _fixup_st_arguments(element, compiler, **kw):
182182
"""
183183
argument_types = _argument_types.get(element.name.lower())
184184
if argument_types:
185-
new_clauses = []
186-
modified = False
187185
for argument_type, argument in zip(argument_types, element.clauses.clauses):
188186
if isinstance(argument, BindParameter) and not isinstance(
189187
argument.type, argument_type
190188
):
191189
argument.type = argument_type()
192-
if issubclass(argument_type, GEOGRAPHY):
193-
argument = geoalchemy2.functions.ST_GeogFromText(argument)
194-
modified = True
195-
new_clauses.append(argument)
196-
if modified:
197-
element.clauses.clauses = new_clauses
198190

199191
return compiler.visit_function(element, **kw)
200192

packages/sqlalchemy-bigquery/tests/system/test_geography.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -222,7 +222,7 @@ class Lake(Base):
222222

223223
from sqlalchemy import func
224224

225-
query = session.query(Lake).filter(func.ST_Contains(Lake.geog, "POINT(4 1)"))
225+
query = session.query(Lake).filter(func.ST_Contains(Lake.geog, WKT("POINT(4 1)")))
226226

227227
assert [lake.name for lake in query] == ["Orta"]
228228

0 commit comments

Comments
 (0)