fix: linting issues and add backward compatibility aliases for internal client_helpers methods

Author: hebaalazzeh

packages/google-api-core/google/api_core/gapic_v1/client_helpers.py

@@ -128,7 +128,7 @@ def get_api_endpoint(
     else:
         return default_endpoint_template.format(
             UNIVERSE_DOMAIN=universe_domain
-        )
+        )  # noqa: E501
 
 
 def read_environment_variables() -> Tuple[bool, str, Optional[str]]:
@@ -149,7 +149,7 @@ def read_environment_variables() -> Tuple[bool, str, Optional[str]]:
     use_client_cert = use_client_cert_effective()
     use_mtls_endpoint = os.getenv(
         "GOOGLE_API_USE_MTLS_ENDPOINT", "auto"
-    ).lower()
+    ).lower()  # noqa: E501
     universe_domain_env = os.getenv("GOOGLE_CLOUD_UNIVERSE_DOMAIN")
     if use_mtls_endpoint not in ("auto", "never", "always"):
         raise MutualTLSChannelError(
@@ -216,7 +216,7 @@ def get_universe_domain(
 
 def setup_request_id(
     request: Any, field_name: str, is_proto3_optional: bool
-) -> None:
+) -> None:  # noqa: E501
     """Populate a UUID4 field in the request if it is not already set.
 
     Args:
@@ -245,3 +245,13 @@ def setup_request_id(
     else:
         if not getattr(request, field_name):
             setattr(request, field_name, str(uuid.uuid4()))
+
+
+# Backward compatibility aliases for private methods
+# Previously, gapic-generator-python generated clients used these methods
+_use_client_cert_effective = use_client_cert_effective
+_get_default_mtls_endpoint = get_default_mtls_endpoint
+_read_environment_variables = read_environment_variables
+_get_client_cert_source = get_client_cert_source
+_get_universe_domain = get_universe_domain
+_setup_request_id = setup_request_id

packages/google-api-core/tests/unit/gapic/test_client_helpers.py

@@ -153,7 +153,7 @@ def test_get_api_endpoint_mtls_universe_mismatch():
 
 @mock.patch(
     "google.api_core.gapic_v1.client_helpers.use_client_cert_effective"
-)
+)  # noqa: E501
 @mock.patch.dict(os.environ, clear=True)
 def test_read_environment_variables(mock_effective):
     mock_effective.return_value = True
@@ -177,10 +177,10 @@ def test_read_environment_variables_invalid_mtls():
 
 @mock.patch(
     "google.auth.transport.mtls.has_default_client_cert_source", create=True
-)
+)  # noqa: E501
 @mock.patch(
     "google.auth.transport.mtls.default_client_cert_source", create=True
-)
+)  # noqa: E501
 def test_get_client_cert_source(mock_default, mock_has_default):
     mock_default.return_value = b"default_cert"
     mock_has_default.return_value = True
@@ -190,9 +190,8 @@ def test_get_client_cert_source(mock_default, mock_has_default):
 
     # When provided_cert_source is given, return provided
     assert (
-        client_helpers.get_client_cert_source(b"provided", True)
-        == b"provided"
-    )
+        client_helpers.get_client_cert_source(b"provided", True) == b"provided"
+    )  # noqa: E501
 
     # When no provided cert but default is available
     assert client_helpers.get_client_cert_source(None, True) == b"default_cert"
@@ -203,20 +202,20 @@ def test_get_universe_domain():
     assert (
         client_helpers.get_universe_domain(
             "client.com", "env.com", "default.com"
-        )
+        )  # noqa: E501
         == "client.com"
     )
 
     # env takes precedence over default
     assert (
         client_helpers.get_universe_domain(None, "env.com", "default.com")
-        == "env.com"
+        == "env.com"  # noqa: E501
     )
 
     # fallback to default
     assert (
         client_helpers.get_universe_domain(None, None, "default.com")
-        == "default.com"
+        == "default.com"  # noqa: E501
     )