Skip to content

Commit 77c1df6

Browse files
authored
test: adds storage to list of system tests to run (#16578)
1. Ensures that `google-cloud-storage` system tests run when a PR is created OR a new commit is pushed to an existing PR that includes files from the google-cloud-storage package. 2. Sorts the list lexigraphically. NOTE for googlers: this is paired with a similar list on google3 and should match. Partially resolves #16487 🦕
1 parent 6cb5af5 commit 77c1df6

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

.kokoro/system.sh

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -96,15 +96,16 @@ packages_with_system_tests=(
9696
"google-cloud-datastore"
9797
"google-cloud-dns"
9898
"google-cloud-error-reporting"
99-
"sqlalchemy-spanner"
10099
"google-cloud-firestore"
101100
"google-cloud-logging"
102101
"google-cloud-ndb"
103102
"google-cloud-pubsub"
104103
"google-cloud-spanner"
104+
"google-cloud-storage"
105105
"google-cloud-testutils"
106-
"sqlalchemy-bigquery"
107106
"pandas-gbq"
107+
"sqlalchemy-bigquery"
108+
"sqlalchemy-spanner"
108109
)
109110

110111
# A file for running system tests

packages/google-cloud-storage/noxfile.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -334,7 +334,7 @@ def system(session, test_type):
334334
session.skip(
335335
"Credentials must be set via environment variable GOOGLE_APPLICATION_CREDENTIALS"
336336
)
337-
# mTLS tests requires pyopenssl.
337+
# Install pyopenssl for mTLS testing.
338338
if os.environ.get("GOOGLE_API_USE_CLIENT_CERTIFICATE", "") == "true":
339339
session.install("pyopenssl")
340340
# Check if endpoint is being overriden for rerun_count

0 commit comments

Comments
 (0)