Skip to content

Commit 789bd5a

Browse files
fixes
1 parent cd64929 commit 789bd5a

2 files changed

Lines changed: 6 additions & 6 deletions

File tree

packages/bigframes/bigframes/session/bq_caching_executor.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ def to_sql(
129129
else array_value.node
130130
)
131131
node = self._substitute_large_local_sources(node)
132-
compiled = compile.compiler().compile_sql(
132+
compiled = compile.compile_sql(
133133
compile.CompileRequest(node, sort_rows=ordered),
134134
compiler_name=self._compiler_name,
135135
)
@@ -256,7 +256,7 @@ def _export_gbq(
256256
# validate destination table
257257
existing_table = self._maybe_find_existing_table(spec)
258258

259-
compiled = compile.compiler().compile_sql(
259+
compiled = compile.compile_sql(
260260
compile.CompileRequest(plan, sort_rows=False),
261261
compiler_name=self._compiler_name,
262262
)

packages/bigframes/tests/unit/session/test_proxy_executor.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ def test_execute_experimental_routes_to_sqlglot(mock_executor, monkeypatch):
6565
monkeypatch.setattr(bigframes.options.experiments, "sql_compiler", "experimental")
6666
mock_executor.execute(array_value, execution_spec)
6767

68-
execution_spec.add_labels.assert_called_once_with(("bigframes-compiler", "sqlglot"))
68+
execution_spec.add_labels.assert_called_once_with({"bigframes-compiler": "sqlglot"})
6969
mock_executor._sqlglot_executor.execute.assert_called_once_with(
7070
array_value, execution_spec
7171
)
@@ -86,7 +86,7 @@ def test_execute_stable_routes_to_sqlglot_success(mock_executor, monkeypatch):
8686
mock_executor.execute(array_value, execution_spec)
8787

8888
execution_spec.add_labels.assert_called_once_with(
89-
("bigframes-compiler", "sqlglot-123456789012")
89+
{"bigframes-compiler": "sqlglot-123456789012"}
9090
)
9191
mock_executor._sqlglot_executor.execute.assert_called_once_with(
9292
array_value, execution_spec
@@ -117,8 +117,8 @@ def test_execute_stable_routes_to_sqlglot_fallback_to_ibis(mock_executor, monkey
117117

118118
execution_spec.add_labels.assert_has_calls(
119119
[
120-
mock.call(("bigframes-compiler", "sqlglot-123456789012")),
121-
mock.call(("bigframes-compiler", "ibis-123456789012")),
120+
mock.call({"bigframes-compiler": "sqlglot-123456789012"}),
121+
mock.call({"bigframes-compiler": "ibis-123456789012"}),
122122
]
123123
)
124124

0 commit comments

Comments
 (0)