Skip to content

Commit 7caecfc

Browse files
committed
don't send metrics in emulator mode
1 parent 3789937 commit 7caecfc

2 files changed

Lines changed: 35 additions & 24 deletions

File tree

  • packages/google-cloud-bigtable/google/cloud/bigtable/data

packages/google-cloud-bigtable/google/cloud/bigtable/data/_async/client.py

Lines changed: 18 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -266,19 +266,24 @@ def __init__(
266266
"is the default."
267267
)
268268
self._is_closed = CrossSync.Event()
269-
# create a metrics exporter using the same client configuration
270-
self._gcp_metrics_exporter = BigtableMetricsExporter(
271-
project_id=self.project,
272-
credentials=credentials,
273-
client_options=client_options,
274-
)
275-
self._metrics_handler = GoogleCloudMetricsHandler(
276-
exporter=self._gcp_metrics_exporter,
277-
client_version=self._client_version(),
278-
)
279-
self._metrics = BigtableClientSideMetricsController(
280-
handlers=[self._metrics_handler]
281-
)
269+
if os.getenv("BIGTABLE_EMULATOR_HOST"):
270+
self._gcp_metrics_exporter = None
271+
self._metrics_handler = None
272+
self._metrics = BigtableClientSideMetricsController(handlers=[])
273+
else:
274+
# create a metrics exporter using the same client configuration
275+
self._gcp_metrics_exporter = BigtableMetricsExporter(
276+
project_id=self.project,
277+
credentials=credentials,
278+
client_options=client_options,
279+
)
280+
self._metrics_handler = GoogleCloudMetricsHandler(
281+
exporter=self._gcp_metrics_exporter,
282+
client_version=self._client_version(),
283+
)
284+
self._metrics = BigtableClientSideMetricsController(
285+
handlers=[self._metrics_handler]
286+
)
282287
self.transport = cast(TransportType, self._gapic_client.transport)
283288
# keep track of active instances to for warmup on channel refresh
284289
self._active_instances: Set[_WarmedInstanceKey] = set()

packages/google-cloud-bigtable/google/cloud/bigtable/data/_sync_autogen/client.py

Lines changed: 17 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -197,17 +197,23 @@ def __init__(
197197
f"The configured universe domain ({self.universe_domain}) does not match the universe domain found in the credentials ({self._credentials.universe_domain}). If you haven't configured the universe domain explicitly, `googleapis.com` is the default."
198198
)
199199
self._is_closed = CrossSync._Sync_Impl.Event()
200-
self._gcp_metrics_exporter = BigtableMetricsExporter(
201-
project_id=self.project,
202-
credentials=credentials,
203-
client_options=client_options,
204-
)
205-
self._metrics_handler = GoogleCloudMetricsHandler(
206-
exporter=self._gcp_metrics_exporter, client_version=self._client_version()
207-
)
208-
self._metrics = BigtableClientSideMetricsController(
209-
handlers=[self._metrics_handler]
210-
)
200+
if os.getenv("BIGTABLE_EMULATOR_HOST"):
201+
self._gcp_metrics_exporter = None
202+
self._metrics_handler = None
203+
self._metrics = BigtableClientSideMetricsController(handlers=[])
204+
else:
205+
self._gcp_metrics_exporter = BigtableMetricsExporter(
206+
project_id=self.project,
207+
credentials=credentials,
208+
client_options=client_options,
209+
)
210+
self._metrics_handler = GoogleCloudMetricsHandler(
211+
exporter=self._gcp_metrics_exporter,
212+
client_version=self._client_version(),
213+
)
214+
self._metrics = BigtableClientSideMetricsController(
215+
handlers=[self._metrics_handler]
216+
)
211217
self.transport = cast(TransportType, self._gapic_client.transport)
212218
self._active_instances: Set[_WarmedInstanceKey] = set()
213219
self._instance_owners: dict[_WarmedInstanceKey, Set[int]] = {}

0 commit comments

Comments
 (0)