Skip to content

Commit 800032d

Browse files
authored
chore(generator): update pqc system tests to use grpcio 1.83.0 (#17881)
update pqc system tests to use grpcio 1.83.0 Fixes: #17751
1 parent 6b0d686 commit 800032d

2 files changed

Lines changed: 3 additions & 9 deletions

File tree

packages/gapic-generator/noxfile.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -498,9 +498,7 @@ def showcase_pqc(
498498
"""Run the Showcase PQC verification test suite against grpcio 1.83+ over standard TLS."""
499499
with showcase_library(session, templates=templates, other_opts=other_opts):
500500
session.install("pytest", "pytest-asyncio")
501-
# TODO(https://github.com/googleapis/google-cloud-python/issues/17751):
502-
# Update the version below to `1.83.0` once released, and remove `--pre`.
503-
session.install("--pre", "--upgrade", "grpcio>=1.83.0rc0", "grpcio-status>=1.83.0rc0")
501+
session.install("--upgrade", "grpcio>=1.83.0", "grpcio-status>=1.83.0")
504502
session.run("py.test", "--quiet", "--tls", *(session.posargs or ["tests/system/test_pqc.py"]), env=env)
505503

506504

packages/gapic-generator/tests/system/test_pqc.py

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -45,9 +45,7 @@ def test_pqc_grpc(intercepted_echo_grpc):
4545
"""Verifies that the gRPC client library negotiates post-quantum MLKEM with Showcase server."""
4646
# TODO(https://github.com/googleapis/google-cloud-python/issues/17752):
4747
# Remove this check once grpcio >= 1.83.0 is enforced across all client libraries.
48-
if Version(grpc.__version__) < Version("1.83.0rc0"):
49-
# TODO(https://github.com/googleapis/google-cloud-python/issues/17751):
50-
# Update the version in the check above to `1.83.0` once released.
48+
if Version(grpc.__version__) < Version("1.83.0"):
5149
pytest.skip(f"gRPC PQC negotiation requires grpcio >= 1.83.0 (current: {grpc.__version__})")
5250

5351
client, interceptor = intercepted_echo_grpc
@@ -69,9 +67,7 @@ async def test_pqc_grpc_async(intercepted_echo_grpc_async):
6967
"""Verifies that the async gRPC client library negotiates post-quantum MLKEM with Showcase server."""
7068
# TODO(https://github.com/googleapis/google-cloud-python/issues/17752):
7169
# Remove this check once grpcio >= 1.83.0 is enforced across all client libraries.
72-
if Version(grpc.__version__) < Version("1.83.0rc0"):
73-
# TODO(https://github.com/googleapis/google-cloud-python/issues/17751):
74-
# Update the version in the check above to `1.83.0` once released.
70+
if Version(grpc.__version__) < Version("1.83.0"):
7571
pytest.skip(
7672
f"gRPC PQC negotiation requires grpcio >= 1.83.0 (current: {grpc.__version__})"
7773
)

0 commit comments

Comments
 (0)