Skip to content

Commit 841654e

Browse files
committed
reduce flakiness
1 parent 1fe8ae7 commit 841654e

2 files changed

Lines changed: 10 additions & 3 deletions

File tree

packages/google-cloud-bigtable/tests/unit/data/_async/test_mutations_batcher.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -923,8 +923,12 @@ async def test_timer_flush_end_to_end(self):
923923
for m in mutations:
924924
await instance.append(m)
925925
assert instance._entries_processed_since_last_raise == 0
926-
# let flush trigger due to timer
927-
await CrossSync.sleep(0.1)
926+
# Poll in short intervals to wait for the background timer flush to finish,
927+
# avoiding timing/scheduling flakiness on slower or heavily loaded environments.
928+
for _ in range(50):
929+
if instance._entries_processed_since_last_raise == num_mutations:
930+
break
931+
await CrossSync.sleep(0.05)
928932
assert instance._entries_processed_since_last_raise == num_mutations
929933

930934
@CrossSync.pytest

packages/google-cloud-bigtable/tests/unit/data/_sync_autogen/test_mutations_batcher.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -804,7 +804,10 @@ def test_timer_flush_end_to_end(self):
804804
for m in mutations:
805805
instance.append(m)
806806
assert instance._entries_processed_since_last_raise == 0
807-
CrossSync._Sync_Impl.sleep(0.1)
807+
for _ in range(50):
808+
if instance._entries_processed_since_last_raise == num_mutations:
809+
break
810+
CrossSync._Sync_Impl.sleep(0.05)
808811
assert instance._entries_processed_since_last_raise == num_mutations
809812

810813
def test__execute_mutate_rows(self):

0 commit comments

Comments
 (0)