Skip to content

Commit 8481cb0

Browse files
committed
fixed tests
1 parent 4e46c66 commit 8481cb0

3 files changed

Lines changed: 8 additions & 5 deletions

File tree

packages/google-cloud-bigtable/tests/unit/data/_async/test_mutations_batcher.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -321,7 +321,7 @@ def _make_one(self, table=None, **kwargs):
321321
DeadlineExceeded,
322322
ServiceUnavailable,
323323
)
324-
table._metrics = BigtableClientSideMetricsController([])
324+
table.client._metrics = BigtableClientSideMetricsController([])
325325

326326
return self._get_target_class()(table, **kwargs)
327327

packages/google-cloud-bigtable/tests/unit/data/_metrics/test_gcp_exporter_handler.py

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,8 @@ class TestGoogleCloudMetricsHandler:
4444
def _make_one(self, *args, **kwargs):
4545
return GoogleCloudMetricsHandler(*args, **kwargs)
4646

47-
def test_ctor_defaults(self):
47+
@mock.patch("google.auth.default", return_value=(mock.Mock(), "project"))
48+
def test_ctor_defaults(self, mock_auth):
4849
from google.cloud.bigtable import __version__ as CLIENT_VERSION
4950

5051
expected_exporter = BigtableMetricsExporter("project")
@@ -59,7 +60,8 @@ def test_ctor_defaults(self):
5960
)
6061
assert handler.shared_labels["client_uid"] == uid_mock()
6162

62-
def test_ctor_explicit(self):
63+
@mock.patch("google.auth.default", return_value=(mock.Mock(), "project"))
64+
def test_ctor_explicit(self, mock_auth):
6365
expected_version = "my_version"
6466
expected_uid = "my_uid"
6567
expected_exporter = BigtableMetricsExporter("project")
@@ -125,7 +127,8 @@ def test_close(self):
125127

126128
class TestBigtableMetricsExporter:
127129
def _make_one(self, *args, **kwargs):
128-
return BigtableMetricsExporter(*args, **kwargs)
130+
with mock.patch("google.auth.default", return_value=(mock.Mock(), "project")):
131+
return BigtableMetricsExporter(*args, **kwargs)
129132

130133
def test_ctor_defaults(self):
131134
from google.cloud.monitoring_v3 import MetricServiceClient

packages/google-cloud-bigtable/tests/unit/data/_sync_autogen/test_mutations_batcher.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -272,7 +272,7 @@ def _make_one(self, table=None, **kwargs):
272272
DeadlineExceeded,
273273
ServiceUnavailable,
274274
)
275-
table._metrics = BigtableClientSideMetricsController([])
275+
table.client._metrics = BigtableClientSideMetricsController([])
276276
return self._get_target_class()(table, **kwargs)
277277

278278
@staticmethod

0 commit comments

Comments
 (0)