Skip to content

Commit 87181fc

Browse files
committed
address feedback
1 parent b910d0f commit 87181fc

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

packages/google-auth/noxfile.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -159,12 +159,12 @@ def mypy(session):
159159

160160

161161
@nox.session(python=ALL_PYTHON)
162-
@nox.parametrize(["install_deprecated_extras"], (True, False))
163-
def unit(session, install_deprecated_extras):
162+
@nox.parametrize(["install_extras"], (True, False))
163+
def unit(session, install_extras):
164164
# Install all test dependencies, then install this package in-place.
165165

166166
min_py, max_py = UNIT_TEST_PYTHON_VERSIONS[0], UNIT_TEST_PYTHON_VERSIONS[-1]
167-
if not install_deprecated_extras and session.python not in (min_py, max_py):
167+
if not install_extras and session.python not in (min_py, max_py):
168168
# only run double tests on first and last supported versions
169169
session.skip(
170170
f"Extended tests only run on boundary Python versions ({min_py}, {max_py}) to reduce CI load."
@@ -177,7 +177,7 @@ def unit(session, install_deprecated_extras):
177177
CURRENT_DIRECTORY / "testing" / f"constraints-extras-{session.python}.txt"
178178
)
179179

180-
if install_deprecated_extras:
180+
if install_extras:
181181
# rsa and oauth2client were both archived and support dropped,
182182
# but we still test old code paths
183183
session.install("oauth2client")
@@ -188,7 +188,7 @@ def unit(session, install_deprecated_extras):
188188
install_args = ["-e", extra_str]
189189
if constraints_path.exists():
190190
install_args.extend(["-c", str(constraints_path)])
191-
if install_deprecated_extras and extras_constraints_path.exists():
191+
if install_extras and extras_constraints_path.exists():
192192
install_args.extend(["-c", str(extras_constraints_path)])
193193

194194
session.install(*install_args)

0 commit comments

Comments
 (0)