Skip to content

Commit 88bc4a7

Browse files
Apply suggestions from code review
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
1 parent cb107af commit 88bc4a7

1 file changed

Lines changed: 6 additions & 6 deletions

File tree

packages/bigframes/specs/bigframes-bigquery-contributing.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ The goal of the [bigframes.bigquery APIs](https://dataframes.bigquery.dev/refere
44
is to provide the simplest possible mapping from BigQuery (GoogleSQL)
55
[functions](https://docs.cloud.google.com/bigquery/docs/reference/standard-sql/functions-all) and
66
[operations](https://docs.cloud.google.com/bigquery/docs/reference/standard-sql/query-syntax) to Python. "Simplest" is somewhat ambiguous
7-
though, when it comes to the types involved an behaviors, so this document aims to expand on that vision with specific examples.
7+
though, when it comes to the types involved and behaviors, so this document aims to expand on that vision with specific examples.
88

99

1010
## SQL and BigFrames expression types
@@ -237,7 +237,7 @@ Arguments in Python can be one of:
237237
* Keyword-only
238238
* All other arguments should be keyword-only. Use `, * ,` Python syntax to achieve this.
239239

240-
For optional parameters, use an optional sentinel (see: https://stackoverflow.com/a/76606310/101923) and omit the value from the generated SQL if the user doesn't explicitly provide one. This ensures that an explicit NULL / None value can be passed in. \
240+
For optional parameters, use an optional sentinel (see: https://stackoverflow.com/a/76606310/101923) and omit the value from the generated SQL if the user doesn't explicitly provide one. This ensures that an explicit NULL / None value can be passed in.
241241

242242

243243

@@ -264,7 +264,7 @@ def spam(*, ham: list[str] | None | Default = DEFAULT):
264264

265265
### Scalar operations types policies
266266

267-
Many operations output a table expression. For these, the output type is always a DataFrame, regardless of the the input types.
267+
Many operations output a table expression. For these, the output type is always a DataFrame, regardless of the input types.
268268

269269
For scalar operations, there are three cases to consider when determining the output types:
270270

@@ -501,8 +501,8 @@ Python usage:
501501
```
502502
unpivotted = bbq.unpivot(
503503
my_produce_dataframe,
504-
aggregation=bpd.col("sales").sum(),
505-
input_column="quarter",
506-
pivot_columns=["Q1", "Q2", "Q3", "Q4"],
504+
values_column="sales",
505+
name_column="quarter",
506+
columns_to_unpivot=["Q1", "Q2", "Q3", "Q4"],
507507
)
508508
```

0 commit comments

Comments
 (0)