Skip to content

Commit 8e79f77

Browse files
committed
fixed issues after merging main
1 parent b62a340 commit 8e79f77

File tree

2 files changed

+49
-2
lines changed

2 files changed

+49
-2
lines changed

packages/google-cloud-firestore/google/cloud/firestore_v1/pipeline_expressions.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3241,7 +3241,9 @@ class Score(FunctionExpression):
32413241
"""
32423242

32433243
def __init__(self):
3244-
super().__init__("score", [], use_infix_repr=False)
3244+
super().__init__(
3245+
"score", [], repr_function=FunctionExpression._build_standalone_repr()
3246+
)
32453247

32463248

32473249
class DocumentMatches(BooleanExpression):
@@ -3266,7 +3268,7 @@ def __init__(self, query: Expression | str):
32663268
super().__init__(
32673269
"document_matches",
32683270
[Expression._cast_to_expr_or_convert_to_constant(query)],
3269-
use_infix_repr=False,
3271+
repr_function=FunctionExpression._build_standalone_repr(),
32703272
)
32713273

32723274

packages/google-cloud-firestore/tests/system/pipeline_e2e/logical.yaml

Lines changed: 45 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -786,6 +786,51 @@ tests:
786786
assert_results:
787787
- title: "Crime and Punishment"
788788
- title: "The Great Gatsby"
789+
assert_proto:
790+
pipeline:
791+
stages:
792+
- args:
793+
- referenceValue: /books
794+
name: collection
795+
- args:
796+
- functionValue:
797+
args:
798+
- functionValue:
799+
args:
800+
- fieldReferenceValue: genre
801+
- stringValue: Romance
802+
name: equal
803+
- functionValue:
804+
args:
805+
- fieldReferenceValue: genre
806+
- stringValue: Dystopian
807+
name: equal
808+
- functionValue:
809+
args:
810+
- fieldReferenceValue: genre
811+
- stringValue: Fantasy
812+
name: equal
813+
- functionValue:
814+
args:
815+
- fieldReferenceValue: published
816+
- integerValue: '1949'
817+
name: greater_than
818+
name: nor
819+
name: where
820+
- args:
821+
- mapValue:
822+
fields:
823+
title:
824+
fieldReferenceValue: title
825+
name: select
826+
- args:
827+
- mapValue:
828+
fields:
829+
direction:
830+
stringValue: ascending
831+
expression:
832+
fieldReferenceValue: title
833+
name: sort
789834
- description: expression_between
790835
pipeline:
791836
- Collection: restaurants

0 commit comments

Comments
 (0)