fix(generator): fix proto-plus field check in setup_request_id fallback

Author: hebaalazzeh

packages/gapic-generator/gapic/templates/%namespace/%name_%version/%sub/_compat.py.j2

@@ -32,7 +32,7 @@ except ImportError:  # pragma: NO COVER
                     setattr(request, field_name, request_id_val)
             except (AttributeError, ValueError):
                 # Proto-plus messages or other objects
-                if getattr(request, field_name, None) is None:
+                if not getattr(request, field_name, None):
                     setattr(request, field_name, request_id_val)
         else:
             if not getattr(request, field_name, None):

packages/gapic-generator/tests/integration/goldens/asset/google/cloud/asset_v1/_compat.py

@@ -45,7 +45,7 @@ def setup_request_id(request, field_name: str, is_proto3_optional: bool):  # pra
                     setattr(request, field_name, request_id_val)
             except (AttributeError, ValueError):
                 # Proto-plus messages or other objects
-                if getattr(request, field_name, None) is None:
+                if not getattr(request, field_name, None):
                     setattr(request, field_name, request_id_val)
         else:
             if not getattr(request, field_name, None):

packages/gapic-generator/tests/integration/goldens/credentials/google/iam/credentials_v1/_compat.py

@@ -45,7 +45,7 @@ def setup_request_id(request, field_name: str, is_proto3_optional: bool):  # pra
                     setattr(request, field_name, request_id_val)
             except (AttributeError, ValueError):
                 # Proto-plus messages or other objects
-                if getattr(request, field_name, None) is None:
+                if not getattr(request, field_name, None):
                     setattr(request, field_name, request_id_val)
         else:
             if not getattr(request, field_name, None):

packages/gapic-generator/tests/integration/goldens/eventarc/google/cloud/eventarc_v1/_compat.py

@@ -45,7 +45,7 @@ def setup_request_id(request, field_name: str, is_proto3_optional: bool):  # pra
                     setattr(request, field_name, request_id_val)
             except (AttributeError, ValueError):
                 # Proto-plus messages or other objects
-                if getattr(request, field_name, None) is None:
+                if not getattr(request, field_name, None):
                     setattr(request, field_name, request_id_val)
         else:
             if not getattr(request, field_name, None):

packages/gapic-generator/tests/integration/goldens/logging/google/cloud/logging_v2/_compat.py

@@ -45,7 +45,7 @@ def setup_request_id(request, field_name: str, is_proto3_optional: bool):  # pra
                     setattr(request, field_name, request_id_val)
             except (AttributeError, ValueError):
                 # Proto-plus messages or other objects
-                if getattr(request, field_name, None) is None:
+                if not getattr(request, field_name, None):
                     setattr(request, field_name, request_id_val)
         else:
             if not getattr(request, field_name, None):

packages/gapic-generator/tests/integration/goldens/logging_internal/google/cloud/logging_v2/_compat.py

@@ -45,7 +45,7 @@ def setup_request_id(request, field_name: str, is_proto3_optional: bool):  # pra
                     setattr(request, field_name, request_id_val)
             except (AttributeError, ValueError):
                 # Proto-plus messages or other objects
-                if getattr(request, field_name, None) is None:
+                if not getattr(request, field_name, None):
                     setattr(request, field_name, request_id_val)
         else:
             if not getattr(request, field_name, None):

packages/gapic-generator/tests/integration/goldens/redis/google/cloud/redis_v1/_compat.py

@@ -45,7 +45,7 @@ def setup_request_id(request, field_name: str, is_proto3_optional: bool):  # pra
                     setattr(request, field_name, request_id_val)
             except (AttributeError, ValueError):
                 # Proto-plus messages or other objects
-                if getattr(request, field_name, None) is None:
+                if not getattr(request, field_name, None):
                     setattr(request, field_name, request_id_val)
         else:
             if not getattr(request, field_name, None):

packages/gapic-generator/tests/integration/goldens/redis_selective/google/cloud/redis_v1/_compat.py

@@ -45,7 +45,7 @@ def setup_request_id(request, field_name: str, is_proto3_optional: bool):  # pra
                     setattr(request, field_name, request_id_val)
             except (AttributeError, ValueError):
                 # Proto-plus messages or other objects
-                if getattr(request, field_name, None) is None:
+                if not getattr(request, field_name, None):
                     setattr(request, field_name, request_id_val)
         else:
             if not getattr(request, field_name, None):

packages/gapic-generator/tests/integration/goldens/storagebatchoperations/google/cloud/storagebatchoperations_v1/_compat.py

@@ -45,7 +45,7 @@ def setup_request_id(request, field_name: str, is_proto3_optional: bool):  # pra
                     setattr(request, field_name, request_id_val)
             except (AttributeError, ValueError):
                 # Proto-plus messages or other objects
-                if getattr(request, field_name, None) is None:
+                if not getattr(request, field_name, None):
                     setattr(request, field_name, request_id_val)
         else:
             if not getattr(request, field_name, None):